diff options
author | Braden Kelley <redbmk@gmail.com> | 2024-06-26 22:30:06 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-27 14:30:06 +0900 |
commit | a0ad5f938ac0b7a1b74c45fa56529f3e3f3342e6 (patch) | |
tree | bba5ad5d69e9621901b6c801e3a611e0ce6bfda5 /test/fixers/test_biome_fixer_callback.vader | |
parent | ed0b036220705e259ab574861016d1c53fdf6de8 (diff) | |
download | ale-a0ad5f938ac0b7a1b74c45fa56529f3e3f3342e6.zip |
fix!(biome): allow passing options to `biome check` (#4799)
The only option available to biome's `lsp-proxy` command used for
linting is `--config-path`. However, we are using ALE to find and set
the project root, and have a way to manually override, so that is no
longer necessary.
The LSP proxy also used the `g:ale_biome_options` config, which is
shared with the fixer's `check` command, but `lsp-proxy` will throw an
error if unknown options are included, making it so that option is only
useful to set the project root.
BREAKING CHANGE: We are no longer passing options to the biome LSP
proxy, but we can still set the project root with
`g:ale_biome_lsp_project_root`.
Diffstat (limited to 'test/fixers/test_biome_fixer_callback.vader')
-rw-r--r-- | test/fixers/test_biome_fixer_callback.vader | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/test/fixers/test_biome_fixer_callback.vader b/test/fixers/test_biome_fixer_callback.vader index 2922b3e6..3d2083e4 100644 --- a/test/fixers/test_biome_fixer_callback.vader +++ b/test/fixers/test_biome_fixer_callback.vader @@ -11,7 +11,7 @@ After: call ale#assert#TearDownFixerTest() Execute(The default biome command should be correct): - call ale#test#SetFilename('../test-files/typescript/test.ts') + call ale#test#SetFilename('../test-files/biome/jsonc/src/test.ts') AssertFixer \ { @@ -21,7 +21,7 @@ Execute(The default biome command should be correct): \ } Execute(Unsafe fixes can be applied via an option): - call ale#test#SetFilename('../test-files/typescript/test.ts') + call ale#test#SetFilename('../test-files/biome/jsonc/src/test.ts') let g:ale_biome_fixer_apply_unsafe = 1 AssertFixer @@ -30,3 +30,14 @@ Execute(Unsafe fixes can be applied via an option): \ 'command': ale#Escape('biome') \ . ' check --apply-unsafe %t' \ } + +Execute(The fixer should accept options): + call ale#test#SetFilename('../test-files/biome/jsonc/src/test.ts') + let g:ale_biome_options = '--foobar' + + AssertFixer + \ { + \ 'read_temporary_file': 1, + \ 'command': ale#Escape('biome') + \ . ' check --apply --foobar %t', + \ } |