Massively reduce the amount of code needed for linter tests

1 files changed, 8 insertions, 25 deletions

diff --git a/test/command_callback/test_pyflakes_command_callback.vader b/test/command_callback/test_pyflakes_command_callback.vader
index 491432e9..efc925fe 100644
--- a/test/command_callback/test_pyflakes_command_callback.vader
+++ b/test/command_callback/test_pyflakes_command_callback.vader
@@ -1,34 +1,20 @@
 Before:
-  Save g:ale_python_pyflakes_executable
-  Save g:ale_python_pyflakes_use_global
-
-  unlet! g:ale_python_pyflakes_executable
-  unlet!  g:ale_python_pyflakes_use_global
-
+  call ale#assert#SetUpLinterTest('python', 'pyflakes')
   let b:bin_dir = has('win32') ? 'Scripts' : 'bin'
 
-  call ale#test#SetDirectory('/testplugin/test/command_callback')
-
-  runtime ale_linters/python/pyflakes.vim
-
 After:
-  Restore
-
   unlet! b:bin_dir
   unlet! b:executable
-
-  call ale#test#RestoreDirectory()
-  call ale#linter#Reset()
+  call ale#assert#TearDownLinterTest()
 
 Execute(The pyflakes command callback should return default string):
-  AssertEqual ale#Escape('pyflakes') . ' %t',
-  \ ale_linters#python#pyflakes#GetCommand(bufnr(''))
+  AssertLinter 'pyflakes', ale#Escape('pyflakes') . ' %t'
 
 Execute(The pyflakes executable should be configurable):
   let g:ale_python_pyflakes_executable = '~/.local/bin/pyflakes'
 
-  AssertEqual ale#Escape('~/.local/bin/pyflakes') . ' %t',
-  \ ale_linters#python#pyflakes#GetCommand(bufnr(''))
+  AssertLinter '~/.local/bin/pyflakes',
+  \ ale#Escape('~/.local/bin/pyflakes') . ' %t'
 
 Execute(The pyflakes executable should be run from the virtualenv path):
   call ale#test#SetFilename('python_paths/with_virtualenv/subdir/foo/bar.py')
@@ -37,20 +23,17 @@ Execute(The pyflakes executable should be run from the virtualenv path):
   \ g:dir . '/python_paths/with_virtualenv/env/' . b:bin_dir . '/pyflakes'
   \)
 
-  AssertEqual ale#Escape(b:executable) . ' %t',
-  \ ale_linters#python#pyflakes#GetCommand(bufnr(''))
+  AssertLinter b:executable, ale#Escape(b:executable) . ' %t'
 
 Execute(You should be able to override the pyflakes virtualenv lookup):
   call ale#test#SetFilename('python_paths/with_virtualenv/subdir/foo/bar.py')
 
   let g:ale_python_pyflakes_use_global = 1
 
-  AssertEqual ale#Escape('pyflakes') . ' %t',
-  \ ale_linters#python#pyflakes#GetCommand(bufnr(''))
+  AssertLinter 'pyflakes', ale#Escape('pyflakes') . ' %t'
 
 Execute(Setting executable to 'pipenv' appends 'run pyflakes'):
   let g:ale_python_pyflakes_executable = 'path/to/pipenv'
 
-  AssertEqual
+  AssertLinter 'path/to/pipenv',
   \ ale#Escape('path/to/pipenv') . ' run pyflakes %t',
-  \ ale_linters#python#pyflakes#GetCommand(bufnr(''))