diff options
author | Magnus Groß <21310755+vimpostor@users.noreply.github.com> | 2023-09-05 15:36:17 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-09-05 14:36:17 +0100 |
commit | 59e455b4d8cf70521fd0f551e91d584294a9af46 (patch) | |
tree | 55c990f23f233d2ceb715d1ed9f3d3da94867af2 /doc/ale-supported-languages-and-tools.txt | |
parent | ea27441834de203c9a8b080d7fbdaa8719f78a52 (diff) | |
download | ale-59e455b4d8cf70521fd0f551e91d584294a9af46.zip |
Improve ALEFix performance for neovim (#3974)
* Avoid performance problems with setbufline() and Treesitter
Call nvim_buf_set_lines() instead.
Since this is a performance problem only in Neovim (Treesitter is only
available there), it doesn't matter that this API is unavailable in Vim.
Note: nvim_buf_set_lines() returns E5555, when set nomodifiable is on.
Fixes #3669
* Avoid sign flickering
The signs flickered because nvim_buf_set_lines() removes all signs from
lines that it touches, which will immediately be readded by Ale (causing
the brief flicker). This is intended behaviour in neovim [0].
Neovim itself faced this problem in their own LSP formatting sync,
although they had the problem with marks instead of signs [1].
Similar to how neovim fixed it by storing and restoring the marks [2],
we can do the same thing with signs.
In fact it is easier with signs, because sign_placelist() will just
ignore and skip invalid line numbers, so we don't need to filter signs
that are not valid anymore.
[0] https://github.com/neovim/neovim/issues/10880#issuecomment-526466042
[1] https://github.com/neovim/neovim/issues/14307
[2] https://github.com/neovim/neovim/pull/14630
Diffstat (limited to 'doc/ale-supported-languages-and-tools.txt')
0 files changed, 0 insertions, 0 deletions