Add a script for custom checks to enforce using the abort flag for functions and trailing whitespace, and fix existing issues.

32 files changed, 38 insertions, 38 deletions

diff --git a/ale_linters/chef/foodcritic.vim b/ale_linters/chef/foodcritic.vim
index 35f5c9b5..bfe73c36 100644
--- a/ale_linters/chef/foodcritic.vim
+++ b/ale_linters/chef/foodcritic.vim
@@ -1,7 +1,7 @@
 " Author: Edward Larkey <edwlarkey@mac.com>
 " Description: This file adds the foodcritic linter for Chef files.
 
-function! ale_linters#chef#foodcritic#Handle(buffer, lines)
+function! ale_linters#chef#foodcritic#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " FC002: Avoid string interpolation where not required: httpd.rb:13
diff --git a/ale_linters/coffee/coffeelint.vim b/ale_linters/coffee/coffeelint.vim
index e1215132..96b8c59d 100644
--- a/ale_linters/coffee/coffeelint.vim
+++ b/ale_linters/coffee/coffeelint.vim
@@ -1,7 +1,7 @@
 " Author: Prashanth Chandra https://github.com/prashcr
 " Description: coffeelint linter for coffeescript files
 
-function! ale_linters#coffee#coffeelint#Handle(buffer, lines)
+function! ale_linters#coffee#coffeelint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " path,lineNumber,lineNumberEnd,level,message
diff --git a/ale_linters/d/dmd.vim b/ale_linters/d/dmd.vim
index 8619eba2..0a6e9bf3 100644
--- a/ale_linters/d/dmd.vim
+++ b/ale_linters/d/dmd.vim
@@ -2,7 +2,7 @@
 " Description: "dmd for D files"
 
 " A function for finding the dmd-wrapper script in the Vim runtime paths
-function! s:FindWrapperScript()
+function! s:FindWrapperScript() abort
     for l:parent in split(&runtimepath, ',')
         " Expand the path to deal with ~ issues.
         let l:path = expand(l:parent . '/' . 'dmd-wrapper')
@@ -13,7 +13,7 @@ function! s:FindWrapperScript()
     endfor
 endfunction
 
-function! ale_linters#d#dmd#GetCommand(buffer)
+function! ale_linters#d#dmd#GetCommand(buffer) abort
     let l:wrapper_script = s:FindWrapperScript()
 
     let l:command = l:wrapper_script . ' -o- -vcolumns -c'
@@ -21,7 +21,7 @@ function! ale_linters#d#dmd#GetCommand(buffer)
     return l:command
 endfunction
 
-function! ale_linters#d#dmd#Handle(buffer, lines)
+function! ale_linters#d#dmd#Handle(buffer, lines) abort
     " Matches patterns lines like the following:
     " /tmp/tmp.qclsa7qLP7/file.d(1): Error: function declaration without return type. (Note that constructors are always named 'this')
     " /tmp/tmp.G1L5xIizvB.d(8,8): Error: module weak_reference is in file 'dstruct/weak_reference.d' which cannot be read
diff --git a/ale_linters/elixir/credo.vim b/ale_linters/elixir/credo.vim
index fe34abc6..4ebecf71 100644
--- a/ale_linters/elixir/credo.vim
+++ b/ale_linters/elixir/credo.vim
@@ -1,6 +1,6 @@
 " Author: hauleth - https://github.com/haulethe
 
-function! ale_linters#elixir#credo#Handle(buffer, lines)
+function! ale_linters#elixir#credo#Handle(buffer, lines) abort
   " Matches patterns line the following:
   "
   " stdin:19: F: Pipe chain should start with a raw value.
diff --git a/ale_linters/elm/make.vim b/ale_linters/elm/make.vim
index abf4beba..35522f1c 100644
--- a/ale_linters/elm/make.vim
+++ b/ale_linters/elm/make.vim
@@ -1,7 +1,7 @@
 " Author: buffalocoder - https://github.com/buffalocoder
 " Description: Elm linting in Ale. Closely follows the Syntastic checker in https://github.com/ElmCast/elm-vim.
 
-function! ale_linters#elm#make#Handle(buffer, lines)
+function! ale_linters#elm#make#Handle(buffer, lines) abort
     let l:output = []
     let l:is_windows = has('win32')
     let l:temp_dir = l:is_windows ? $TMP : $TMPDIR
diff --git a/ale_linters/fortran/gcc.vim b/ale_linters/fortran/gcc.vim
index 4129eca8..73ec7886 100644
--- a/ale_linters/fortran/gcc.vim
+++ b/ale_linters/fortran/gcc.vim
@@ -6,7 +6,7 @@ if !exists('g:ale_fortran_gcc_options')
     let g:ale_fortran_gcc_options = '-Wall'
 endif
 
-function! ale_linters#fortran#gcc#Handle(buffer, lines)
+function! ale_linters#fortran#gcc#Handle(buffer, lines) abort
     " We have to match a starting line and a later ending line together,
     " like so.
     "
diff --git a/ale_linters/haskell/ghc.vim b/ale_linters/haskell/ghc.vim
index def883e3..5ddc15fe 100644
--- a/ale_linters/haskell/ghc.vim
+++ b/ale_linters/haskell/ghc.vim
@@ -7,7 +7,7 @@ endif
 
 let g:loaded_ale_linters_haskell_ghc = 1
 
-function! ale_linters#haskell#ghc#Handle(buffer, lines)
+function! ale_linters#haskell#ghc#Handle(buffer, lines) abort
     " Look for lines like the following.
     "
     " /dev/stdin:28:26: Not in scope: `>>>>>'
diff --git a/ale_linters/haskell/hlint.vim b/ale_linters/haskell/hlint.vim
index 3aa93fa1..5b870e3d 100644
--- a/ale_linters/haskell/hlint.vim
+++ b/ale_linters/haskell/hlint.vim
@@ -1,7 +1,7 @@
 " Author: jparoz <jesse.paroz@gmail.com>
 " Description: hlint for Haskell files
 
-function! ale_linters#haskell#hlint#Handle(buffer, lines)
+function! ale_linters#haskell#hlint#Handle(buffer, lines) abort
     let l:errors = json_decode(join(a:lines, ''))
 
     let l:output = []
diff --git a/ale_linters/javascript/eslint.vim b/ale_linters/javascript/eslint.vim
index 95948fbd..c2794ec8 100644
--- a/ale_linters/javascript/eslint.vim
+++ b/ale_linters/javascript/eslint.vim
@@ -28,7 +28,7 @@ function! ale_linters#javascript#eslint#GetCommand(buffer) abort
     \   . ' -f unix --stdin --stdin-filename %s'
 endfunction
 
-function! ale_linters#javascript#eslint#Handle(buffer, lines)
+function! ale_linters#javascript#eslint#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " /path/to/some-filename.js:47:14: Missing trailing comma. [Warning/comma-dangle]
diff --git a/ale_linters/javascript/flow.vim b/ale_linters/javascript/flow.vim
index f3a12101..f0b81b1d 100644
--- a/ale_linters/javascript/flow.vim
+++ b/ale_linters/javascript/flow.vim
@@ -24,7 +24,7 @@ function! ale_linters#javascript#flow#GetCommand(buffer) abort
   \   . ' check-contents --respect-pragma --json --from ale %s'
 endfunction
 
-function! ale_linters#javascript#flow#Handle(buffer, lines)
+function! ale_linters#javascript#flow#Handle(buffer, lines) abort
   let l:str = join(a:lines, '')
   if l:str ==# ''
     return []
diff --git a/ale_linters/javascript/jshint.vim b/ale_linters/javascript/jshint.vim
index f82011dd..f4b66519 100644
--- a/ale_linters/javascript/jshint.vim
+++ b/ale_linters/javascript/jshint.vim
@@ -19,7 +19,7 @@ function! ale_linters#javascript#jshint#GetExecutable(buffer) abort
     \)
 endfunction
 
-function! ale_linters#javascript#jshint#GetCommand(buffer)
+function! ale_linters#javascript#jshint#GetCommand(buffer) abort
     " Search for a local JShint config locaation, and default to a global one.
     let l:jshint_config = ale#util#ResolveLocalPath(
     \   a:buffer,
diff --git a/ale_linters/json/jsonlint.vim b/ale_linters/json/jsonlint.vim
index ca9a06c4..5af8f625 100644
--- a/ale_linters/json/jsonlint.vim
+++ b/ale_linters/json/jsonlint.vim
@@ -1,6 +1,6 @@
 " Author: KabbAmine <amine.kabb@gmail.com>
 
-function! ale_linters#json#jsonlint#Handle(buffer, lines)
+function! ale_linters#json#jsonlint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     " line 2, col 15, found: 'STRING' - expected: 'EOF', '}', ',', ']'.
 
diff --git a/ale_linters/lua/luacheck.vim b/ale_linters/lua/luacheck.vim
index 9036c317..ace464ce 100644
--- a/ale_linters/lua/luacheck.vim
+++ b/ale_linters/lua/luacheck.vim
@@ -4,7 +4,7 @@
 let g:ale_lua_luacheck_executable =
 \   get(g:, 'ale_lua_luacheck_executable', 'luacheck')
 
-function! ale_linters#lua#luacheck#Handle(buffer, lines)
+function! ale_linters#lua#luacheck#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " artal.lua:159:17: (W111) shadowing definition of loop variable 'i' on line 106
diff --git a/ale_linters/matlab/mlint.vim b/ale_linters/matlab/mlint.vim
index e1e6cf05..302e75ce 100644
--- a/ale_linters/matlab/mlint.vim
+++ b/ale_linters/matlab/mlint.vim
@@ -4,7 +4,7 @@
 let g:ale_matlab_mlint_executable =
 \   get(g:, 'ale_matlab_mlint_executable', 'mlint')
 
-function! ale_linters#matlab#mlint#Handle(buffer, lines)
+function! ale_linters#matlab#mlint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " L 27 (C 1): FNDEF: Terminate statement with semicolon to suppress output.
diff --git a/ale_linters/ocaml/merlin.vim b/ale_linters/ocaml/merlin.vim
index f8e0329e..75cdb126 100644
--- a/ale_linters/ocaml/merlin.vim
+++ b/ale_linters/ocaml/merlin.vim
@@ -5,7 +5,7 @@ if !exists('g:merlin')
   finish
 endif
 
-function! ale_linters#ocaml#merlin#Handle(buffer, lines)
+function! ale_linters#ocaml#merlin#Handle(buffer, lines) abort
   let l:errors = merlin#ErrorLocList()
   return l:errors
 endfunction
diff --git a/ale_linters/perl/perl.vim b/ale_linters/perl/perl.vim
index 28cf787e..3724244e 100644
--- a/ale_linters/perl/perl.vim
+++ b/ale_linters/perl/perl.vim
@@ -1,7 +1,7 @@
 " Author: Vincent Lequertier <https://github.com/SkySymbol>
 " Description: This file adds support for checking perl syntax
 
-function! ale_linters#perl#perl#Handle(buffer, lines)
+function! ale_linters#perl#perl#Handle(buffer, lines) abort
     let l:pattern = '\(.\+\) at \(.\+\) line \(\d\+\)'
     let l:output = []
 
diff --git a/ale_linters/perl/perlcritic.vim b/ale_linters/perl/perlcritic.vim
index d1152bbc..dfad2d48 100644
--- a/ale_linters/perl/perlcritic.vim
+++ b/ale_linters/perl/perlcritic.vim
@@ -1,7 +1,7 @@
 " Author: Vincent Lequertier <https://github.com/SkySymbol>
 " Description: This file adds support for checking perl with perl critic
 
-function! ale_linters#perl#perlcritic#Handle(buffer, lines)
+function! ale_linters#perl#perlcritic#Handle(buffer, lines) abort
     let l:pattern = '\(.\+\) at \(.\+\) line \(\d\+\)'
     let l:output = []
 
diff --git a/ale_linters/php/hack.vim b/ale_linters/php/hack.vim
index bacd835d..5c90247b 100644
--- a/ale_linters/php/hack.vim
+++ b/ale_linters/php/hack.vim
@@ -1,7 +1,7 @@
 " Author: Zefei Xuan <https://github.com/zefei>
 " Description: Hack type checking (http://hacklang.org/)
 
-function! ale_linters#php#hack#Handle(buffer, lines)
+function! ale_linters#php#hack#Handle(buffer, lines) abort
     let l:pattern = '^\(.*\):\(\d\+\):\(\d\+\),\(\d\+\): \(.\+])\)$'
     let l:output = []
 
diff --git a/ale_linters/php/php.vim b/ale_linters/php/php.vim
index 573036d8..b807fee9 100644
--- a/ale_linters/php/php.vim
+++ b/ale_linters/php/php.vim
@@ -1,7 +1,7 @@
 " Author: Spencer Wood <https://github.com/scwood>
 " Description: This file adds support for checking PHP with php-cli
 
-function! ale_linters#php#php#Handle(buffer, lines)
+function! ale_linters#php#php#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " Parse error: parse error in - on line 7
diff --git a/ale_linters/php/phpcs.vim b/ale_linters/php/phpcs.vim
index 6e64d30e..4b3cabdf 100644
--- a/ale_linters/php/phpcs.vim
+++ b/ale_linters/php/phpcs.vim
@@ -1,7 +1,7 @@
 " Author: jwilliams108 <https://github.com/jwilliams108>
 " Description: phpcs for PHP files
 
-function! ale_linters#php#phpcs#GetCommand(buffer)
+function! ale_linters#php#phpcs#GetCommand(buffer) abort
     let l:command = 'phpcs -s --report=emacs --stdin-path=%s'
 
     " This option can be set to change the standard used by phpcs
@@ -12,7 +12,7 @@ function! ale_linters#php#phpcs#GetCommand(buffer)
     return l:command
 endfunction
 
-function! ale_linters#php#phpcs#Handle(buffer, lines)
+function! ale_linters#php#phpcs#Handle(buffer, lines) abort
     " Matches against lines like the following:
     "
     " /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
diff --git a/ale_linters/puppet/puppet.vim b/ale_linters/puppet/puppet.vim
index b00a7ddc..534894cd 100644
--- a/ale_linters/puppet/puppet.vim
+++ b/ale_linters/puppet/puppet.vim
@@ -1,6 +1,6 @@
 " Author: Alexander Olofsson <alexander.olofsson@liu.se>
 
-function! ale_linters#puppet#puppet#Handle(buffer, lines)
+function! ale_linters#puppet#puppet#Handle(buffer, lines) abort
     " Matches patterns like the following:
     " Error: Could not parse for environment production: Syntax error at ':' at /root/puppetcode/modules/nginx/manifests/init.pp:43:12
 
diff --git a/ale_linters/ruby/rubocop.vim b/ale_linters/ruby/rubocop.vim
index 72007016..fad02128 100644
--- a/ale_linters/ruby/rubocop.vim
+++ b/ale_linters/ruby/rubocop.vim
@@ -1,7 +1,7 @@
 " Author: ynonp - https://github.com/ynonp
 " Description: rubocop for Ruby files
 
-function! ale_linters#ruby#rubocop#Handle(buffer, lines)
+function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " <path>/_:47:14: 83:29: C: Prefer single-quoted strings when you don't
diff --git a/ale_linters/rust/cargo.vim b/ale_linters/rust/cargo.vim
index 0f04f275..738821d7 100644
--- a/ale_linters/rust/cargo.vim
+++ b/ale_linters/rust/cargo.vim
@@ -2,7 +2,7 @@
 " Description: rustc invoked by cargo for rust files
 
 
-function! ale_linters#rust#cargo#GetCargoExecutable(bufnr)
+function! ale_linters#rust#cargo#GetCargoExecutable(bufnr) abort
     if ale#util#FindNearestFile(a:bufnr, 'Cargo.toml') !=# ''
         return 'cargo'
     else
diff --git a/ale_linters/scala/scalac.vim b/ale_linters/scala/scalac.vim
index ea13bbd6..c2e7543c 100644
--- a/ale_linters/scala/scalac.vim
+++ b/ale_linters/scala/scalac.vim
@@ -2,7 +2,7 @@
 " Author: Zoltan Kalmar - https://github.com/kalmiz
 " Description: Basic scala support using scalac
 
-function! ale_linters#scala#scalac#Handle(buffer, lines)
+function! ale_linters#scala#scalac#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " /var/folders/5q/20rgxx3x1s34g3m14n5bq0x80000gn/T/vv6pSsy/0:26: error: expected class or object definition
diff --git a/ale_linters/scss/scsslint.vim b/ale_linters/scss/scsslint.vim
index 399082fa..1ee06622 100644
--- a/ale_linters/scss/scsslint.vim
+++ b/ale_linters/scss/scsslint.vim
@@ -1,7 +1,7 @@
 " Author: w0rp <devw0rp@gmail.com>
 " Description: This file add scsslint support for SCSS support
 
-function! ale_linters#scss#scsslint#Handle(buffer, lines)
+function! ale_linters#scss#scsslint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " test.scss:2:1 [W] Indentation: Line should be indented 2 spaces, but was indented 4 spaces
diff --git a/ale_linters/sh/shell.vim b/ale_linters/sh/shell.vim
index f996f7e1..786cc0e6 100644
--- a/ale_linters/sh/shell.vim
+++ b/ale_linters/sh/shell.vim
@@ -11,7 +11,7 @@ if !exists('g:ale_linters_sh_shell_default_shell')
     endif
 endif
 
-function! ale_linters#sh#shell#GetExecutable(buffer)
+function! ale_linters#sh#shell#GetExecutable(buffer) abort
     let l:banglines = getbufline(a:buffer, 1)
 
     " Take the shell executable from the hashbang, if we can.
@@ -29,11 +29,11 @@ function! ale_linters#sh#shell#GetExecutable(buffer)
     return g:ale_linters_sh_shell_default_shell
 endfunction
 
-function! ale_linters#sh#shell#GetCommand(buffer)
+function! ale_linters#sh#shell#GetCommand(buffer) abort
     return ale_linters#sh#shell#GetExecutable(a:buffer) . ' -n'
 endfunction
 
-function! ale_linters#sh#shell#Handle(buffer, lines)
+function! ale_linters#sh#shell#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " bash: line 13: syntax error near unexpected token `d'
diff --git a/ale_linters/sh/shellcheck.vim b/ale_linters/sh/shellcheck.vim
index d0fe8b11..735a0cd3 100644
--- a/ale_linters/sh/shellcheck.vim
+++ b/ale_linters/sh/shellcheck.vim
@@ -16,7 +16,7 @@ else
     let s:exclude_option = ''
 endif
 
-function! s:GetDialectArgument()
+function! s:GetDialectArgument() abort
     if exists('b:is_bash') && b:is_bash
         return '-s bash'
     elseif exists('b:is_sh') && b:is_sh
@@ -28,7 +28,7 @@ function! s:GetDialectArgument()
     return ''
 endfunction
 
-function! ale_linters#sh#shellcheck#GetCommand(buffer)
+function! ale_linters#sh#shellcheck#GetCommand(buffer) abort
   return 'shellcheck ' . s:exclude_option . ' ' . s:GetDialectArgument() . ' -f gcc -'
 endfunction
 
diff --git a/ale_linters/typescript/tslint.vim b/ale_linters/typescript/tslint.vim
index d5405977..eb5b1a7d 100644
--- a/ale_linters/typescript/tslint.vim
+++ b/ale_linters/typescript/tslint.vim
@@ -1,7 +1,7 @@
 " Author: Prashanth Chandra https://github.com/prashcr
 " Description: tslint for TypeScript files
 
-function! ale_linters#typescript#tslint#Handle(buffer, lines)
+function! ale_linters#typescript#tslint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " hello.ts[7, 41]: trailing whitespace
diff --git a/ale_linters/typescript/typecheck.vim b/ale_linters/typescript/typecheck.vim
index 3a237e37..080a2381 100644
--- a/ale_linters/typescript/typecheck.vim
+++ b/ale_linters/typescript/typecheck.vim
@@ -1,7 +1,7 @@
 " Author: Prashanth Chandra https://github.com/prashcr, Aleh Kashnikau https://github.com/mkusher
 " Description: type checker for TypeScript files
 
-function! ale_linters#typescript#typecheck#Handle(buffer, lines)
+function! ale_linters#typescript#typecheck#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
     " hello.ts[7, 41]: Property 'a' does not exist on type 'A'
diff --git a/ale_linters/verilog/iverilog.vim b/ale_linters/verilog/iverilog.vim
index 97d4a1f1..d10661d7 100644
--- a/ale_linters/verilog/iverilog.vim
+++ b/ale_linters/verilog/iverilog.vim
@@ -1,7 +1,7 @@
 " Author: Masahiro H https://github.com/mshr-h
 " Description: iverilog for verilog files
 
-function! ale_linters#verilog#iverilog#Handle(buffer, lines)
+function! ale_linters#verilog#iverilog#Handle(buffer, lines) abort
     " Look for lines like the following.
     "
     " tb_me_top.v:37: warning: Instantiating module me_top with dangling input port 1 (rst_n) floating.
diff --git a/ale_linters/verilog/verilator.vim b/ale_linters/verilog/verilator.vim
index d8e105a2..534e1ae2 100644
--- a/ale_linters/verilog/verilator.vim
+++ b/ale_linters/verilog/verilator.vim
@@ -1,7 +1,7 @@
 " Author: Masahiro H https://github.com/mshr-h
 " Description: verilator for verilog files
 
-function! ale_linters#verilog#verilator#Handle(buffer, lines)
+function! ale_linters#verilog#verilator#Handle(buffer, lines) abort
     " Look for lines like the following.
     "
     " %Error: addr_gen.v:3: syntax error, unexpected IDENTIFIER
diff --git a/ale_linters/yaml/yamllint.vim b/ale_linters/yaml/yamllint.vim
index a541a83d..05af709d 100644
--- a/ale_linters/yaml/yamllint.vim
+++ b/ale_linters/yaml/yamllint.vim
@@ -1,6 +1,6 @@
 " Author: KabbAmine <amine.kabb@gmail.com>
 
-function! ale_linters#yaml#yamllint#Handle(buffer, lines)
+function! ale_linters#yaml#yamllint#Handle(buffer, lines) abort
     " Matches patterns line the following:
     " something.yaml:1:1: [warning] missing document start "---" (document-start)
     " something.yml:2:1: [error] syntax error: expected the node content, but found '<stream end>'