improved the sml linter (#445)

* improved the sml linter

* made matching operator agnostic to user settings

* added tests for sml

1 files changed, 22 insertions, 8 deletions

diff --git a/ale_linters/sml/smlnj.vim b/ale_linters/sml/smlnj.vim
index a227a95d..b1599521 100644
--- a/ale_linters/sml/smlnj.vim
+++ b/ale_linters/sml/smlnj.vim
@@ -12,20 +12,34 @@ function! ale_linters#sml#smlnj#Handle(buffer, lines) abort
 
     let l:out = []
     let l:pattern = '^.*\:\([0-9\.]\+\)\ \(\w\+\)\:\ \(.*\)'
+    let l:pattern2 = '^.*\:\([0-9]\+\)\.\?\([0-9]\+\).* \(\(Warning\|Error\): .*\)'
 
     for l:line in a:lines
+        let l:match2 = matchlist(l:line, l:pattern2)
+
+        if len(l:match2) != 0
+          call add(l:out, {
+          \   'bufnr': a:buffer,
+          \   'lnum': l:match2[1] + 0,
+          \   'col' : l:match2[2] - 1,
+          \   'text': l:match2[3],
+          \   'type': l:match2[3] =~# '^Warning' ? 'W' : 'E',
+          \})
+          continue
+        endif
+
         let l:match = matchlist(l:line, l:pattern)
 
-        if len(l:match) == 0
-            continue
+        if len(l:match) != 0
+          call add(l:out, {
+          \   'bufnr': a:buffer,
+          \   'lnum': l:match[1] + 0,
+          \   'text': l:match[2] . ': ' . l:match[3],
+          \   'type': l:match[2] ==# 'error' ? 'E' : 'W',
+          \})
+          continue
         endif
 
-        call add(l:out, {
-        \   'bufnr': a:buffer,
-        \   'lnum': l:match[1] + 0,
-        \   'text': l:match[2] . ': ' . l:match[3],
-        \   'type': l:match[2] ==# 'error' ? 'E' : 'W',
-        \})
     endfor
 
     return l:out