diff options
author | Nozomu Okuda <Nozomu.Okuda@gmail.com> | 2017-05-24 21:40:06 -0600 |
---|---|---|
committer | Nozomu Okuda <Nozomu.Okuda@gmail.com> | 2017-05-24 21:40:06 -0600 |
commit | 43098171ac8585bd42f78d2f208b717abfaf36c3 (patch) | |
tree | 943fb39fc3b5469076b8ba7d6d26578eae60d917 /ale_linters | |
parent | ed8f79987d5a64c41f8b5c1c244243babde45d25 (diff) | |
download | ale-43098171ac8585bd42f78d2f208b717abfaf36c3.zip |
Translate pylint output column to 1-based index
This should fix #575; also added vader tests to ensure that translation
is working properly.
Diffstat (limited to 'ale_linters')
-rw-r--r-- | ale_linters/python/pylint.vim | 35 |
1 files changed, 34 insertions, 1 deletions
diff --git a/ale_linters/python/pylint.vim b/ale_linters/python/pylint.vim index 4275ada0..57c3870a 100644 --- a/ale_linters/python/pylint.vim +++ b/ale_linters/python/pylint.vim @@ -32,10 +32,43 @@ function! ale_linters#python#pylint#GetCommand(buffer) abort \ . ' %s' endfunction +function! ale_linters#python#pylint#Handle(buffer, lines) abort + " Matches patterns like the following: + " + " test.py:4:4: W0101 (unreachable) Unreachable code + let l:pattern = '\v^[^:]+:(\d+):(\d+): ([[:alnum:]]+) \((.*)\) (.*)$' + let l:output = [] + + for l:match in ale#util#GetMatches(a:lines, l:pattern) + "let l:failed = append(0, l:match) + let l:code = l:match[3] + + if (l:code ==# 'C0303') + \ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace') + " Skip warnings for trailing whitespace if the option is off. + continue + endif + + if l:code ==# 'I0011' + " Skip 'Locally disabling' message + continue + endif + + call add(l:output, { + \ 'lnum': l:match[1] + 0, + \ 'col': l:match[2] + 1, + \ 'text': l:code . ': ' . l:match[5], + \ 'type': l:code[:0] ==# 'E' ? 'E' : 'W', + \}) + endfor + + return l:output +endfunction + call ale#linter#Define('python', { \ 'name': 'pylint', \ 'executable_callback': 'ale_linters#python#pylint#GetExecutable', \ 'command_callback': 'ale_linters#python#pylint#GetCommand', -\ 'callback': 'ale#handlers#python#HandlePEP8Format', +\ 'callback': 'ale_linters#python#pylint#Handle', \ 'lint_file': 1, \}) |