diff options
| author | Adriaan Zonnenberg <adriaanzon@users.noreply.github.com> | 2017-03-31 00:33:38 +0200 |
|---|---|---|
| committer | w0rp <w0rp@users.noreply.github.com> | 2017-03-30 23:33:38 +0100 |
| commit | 4b0f3257ddf4303a00979cd1171dd449bd3b9ed5 (patch) | |
| tree | 22e932441ca241313cc5a918d4c167e9e52f2032 /ale_linters/sml/smlnj.vim | |
| parent | 6c97cd335b33d2160288b992602a0deda2ae5652 (diff) | |
| download | ale-4b0f3257ddf4303a00979cd1171dd449bd3b9ed5.zip | |
Remove 'col' from linters where it is hardcoded to 1 (#434)
* Remove 'col' from linters where it is hardcoded to 1
When 'col' is 1, the first column will get highlighted for no reason. It
should be 0 (which is the default).
In the scalac linter there was also a check about the outcome of
`stridx`. It would set l:col to 0 if it was -1, and then it uses
`'col': l:col + 1` to convert the outcome of `stridx` to the actual
column number. This will make 'col' equals 1 when there is no match. We
can remove the check because `-1 + 1 = 0`.
* Remove outdated comments about vcol
vcol was added as a default, and the loclists that follow these comments
do not contain 'vcol' anymore
Diffstat (limited to 'ale_linters/sml/smlnj.vim')
| -rw-r--r-- | ale_linters/sml/smlnj.vim | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ale_linters/sml/smlnj.vim b/ale_linters/sml/smlnj.vim index c75f89bb..a227a95d 100644 --- a/ale_linters/sml/smlnj.vim +++ b/ale_linters/sml/smlnj.vim @@ -23,7 +23,6 @@ function! ale_linters#sml#smlnj#Handle(buffer, lines) abort call add(l:out, { \ 'bufnr': a:buffer, \ 'lnum': l:match[1] + 0, - \ 'col': 1, \ 'text': l:match[2] . ': ' . l:match[3], \ 'type': l:match[2] ==# 'error' ? 'E' : 'W', \}) |