summaryrefslogtreecommitdiff
path: root/ale_linters/ruby/reek.vim
diff options
context:
space:
mode:
authorw0rp <devw0rp@gmail.com>2018-09-14 13:24:59 +0100
committerw0rp <devw0rp@gmail.com>2018-09-14 13:24:59 +0100
commit5c86ffd321ee42b2c59e8455710474e3c13d3e09 (patch)
tree8c6702aa0fe866f1e7d289f76f4b5bd806847f89 /ale_linters/ruby/reek.vim
parent9e09b7ca3559e2c14ed2401bb666b441b22dafff (diff)
downloadale-5c86ffd321ee42b2c59e8455710474e3c13d3e09.zip
Return only the unescaped executables from executable callbacks
Diffstat (limited to 'ale_linters/ruby/reek.vim')
-rw-r--r--ale_linters/ruby/reek.vim15
1 files changed, 5 insertions, 10 deletions
diff --git a/ale_linters/ruby/reek.vim b/ale_linters/ruby/reek.vim
index 26a26a13..eefc4ecf 100644
--- a/ale_linters/ruby/reek.vim
+++ b/ale_linters/ruby/reek.vim
@@ -6,12 +6,6 @@ call ale#Set('ruby_reek_show_wiki_link', 0)
call ale#Set('ruby_reek_options', '')
call ale#Set('ruby_reek_executable', 'reek')
-function! ale_linters#ruby#reek#GetExecutable(buffer) abort
- let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
-
- return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
-endfunction
-
function! ale_linters#ruby#reek#VersionCheck(buffer) abort
" If we have previously stored the version number in a cache, then
" don't look it up again.
@@ -20,21 +14,22 @@ function! ale_linters#ruby#reek#VersionCheck(buffer) abort
return ''
endif
- let l:executable = ale_linters#ruby#reek#GetExecutable(a:buffer)
+ let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
- return l:executable . ' --version'
+ return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
+ \ . ' --version'
endfunction
function! ale_linters#ruby#reek#GetCommand(buffer, version_output) abort
let l:version = ale#semver#GetVersion('reek', a:version_output)
- let l:executable = ale_linters#ruby#reek#GetExecutable(a:buffer)
+ let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
" Tell reek what the filename is if the version of reek is new enough.
let l:display_name_args = ale#semver#GTE(l:version, [5, 0, 0])
\ ? ' --stdin-filename %s'
\ : ''
- return l:executable
+ return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
\ . ' -f json --no-progress --no-color'
\ . l:display_name_args
endfunction