summaryrefslogtreecommitdiff
path: root/ale_linters/perl
diff options
context:
space:
mode:
authorChris Weyl <chris@weyl.io>2017-06-29 07:08:51 -0500
committerw0rp <w0rp@users.noreply.github.com>2017-06-29 13:08:51 +0100
commit3f1cab3e7ee3d7e90062e32e7d8c9557077c08a8 (patch)
treea4871ee9fdd2ef91a2c825e26e12b12d25965f86 /ale_linters/perl
parent411c6b5e9f8ecf367aaf487adf4e380251c44fa1 (diff)
downloadale-3f1cab3e7ee3d7e90062e32e7d8c9557077c08a8.zip
Add profile, other options to the perlcritic linter (#675)
* Add profile, other options to the perlcritic linter
Diffstat (limited to 'ale_linters/perl')
-rw-r--r--ale_linters/perl/perlcritic.vim51
1 files changed, 44 insertions, 7 deletions
diff --git a/ale_linters/perl/perlcritic.vim b/ale_linters/perl/perlcritic.vim
index 189a9ce3..a9e8f117 100644
--- a/ale_linters/perl/perlcritic.vim
+++ b/ale_linters/perl/perlcritic.vim
@@ -1,17 +1,54 @@
-" Author: Vincent Lequertier <https://github.com/SkySymbol>
+" Author: Vincent Lequertier <https://github.com/SkySymbol>, Chris Weyl <cweyl@alumni.drew.edu>
" Description: This file adds support for checking perl with perl critic
-if !exists('g:ale_perl_perlcritic_showrules')
- let g:ale_perl_perlcritic_showrules = 0
-endif
+let g:ale_perl_perlcritic_executable =
+\ get(g:, 'ale_perl_perlcritic_executable', 'perlcritic')
+
+let g:ale_perl_perlcritic_profile =
+\ get(g:, 'ale_perl_perlcritic_profile', '.perlcriticrc')
+
+let g:ale_perl_perlcritic_options =
+\ get(g:, 'ale_perl_perlcritic_options', '')
+
+let g:ale_perl_perlcritic_showrules =
+\ get(g:, 'ale_perl_perlcritic_showrules', 0)
+
+function! ale_linters#perl#perlcritic#GetExecutable(buffer) abort
+ return ale#Var(a:buffer, 'perl_perlcritic_executable')
+endfunction
+
+function! ale_linters#perl#perlcritic#GetProfile(buffer) abort
+
+ " first see if we've been overridden
+ let l:profile = ale#Var(a:buffer, 'perl_perlcritic_profile')
+ if l:profile ==? ''
+ return ''
+ endif
+
+ " otherwise, iterate upwards to find it
+ return ale#path#FindNearestFile(a:buffer, l:profile)
+endfunction
function! ale_linters#perl#perlcritic#GetCommand(buffer) abort
let l:critic_verbosity = '%l:%c %m\n'
- if g:ale_perl_perlcritic_showrules
+ if ale#Var(a:buffer, 'perl_perlcritic_showrules')
let l:critic_verbosity = '%l:%c %m [%p]\n'
endif
- return "perlcritic --verbose '". l:critic_verbosity . "' --nocolor"
+ let l:profile = ale_linters#perl#perlcritic#GetProfile(a:buffer)
+ let l:options = ale#Var(a:buffer, 'perl_perlcritic_options')
+
+ let l:command = ale#Escape(ale_linters#perl#perlcritic#GetExecutable(a:buffer))
+ \ . " --verbose '". l:critic_verbosity . "' --nocolor"
+
+ if l:profile !=? ''
+ let l:command .= ' --profile ' . ale#Escape(l:profile)
+ endif
+ if l:options !=? ''
+ let l:command .= ' ' . l:options
+ endif
+
+ return l:command
endfunction
@@ -32,8 +69,8 @@ endfunction
call ale#linter#Define('perl', {
\ 'name': 'perlcritic',
-\ 'executable': 'perlcritic',
\ 'output_stream': 'stdout',
+\ 'executable_callback': 'ale_linters#perl#perlcritic#GetExecutable',
\ 'command_callback': 'ale_linters#perl#perlcritic#GetCommand',
\ 'callback': 'ale_linters#perl#perlcritic#Handle',
\})