diff options
| author | Jeff Willette <jrwillette88@gmail.com> | 2017-11-16 01:34:30 +0900 |
|---|---|---|
| committer | w0rp <w0rp@users.noreply.github.com> | 2017-11-15 16:34:30 +0000 |
| commit | e721f851b41b8f6f31067ae2a137019e1cb5546c (patch) | |
| tree | f00d79521ad98dab729325273b3d0db7e8afc4b2 /ale_linters/go | |
| parent | 290ed4885b2f0dbbbe9fcbfb12216f89b2e63924 (diff) | |
| download | ale-e721f851b41b8f6f31067ae2a137019e1cb5546c.zip | |
Show problems from other files for gobuild and gometalinter
* Added filename keys to gobuild and gometalinter
* Removed skipping files not in current package
* Removed `--include` for gometalinter
* Fixed the tests
Diffstat (limited to 'ale_linters/go')
| -rw-r--r-- | ale_linters/go/gobuild.vim | 10 | ||||
| -rw-r--r-- | ale_linters/go/gometalinter.vim | 5 |
2 files changed, 7 insertions, 8 deletions
diff --git a/ale_linters/go/gobuild.vim b/ale_linters/go/gobuild.vim index 143c2fd0..783b9e0a 100644 --- a/ale_linters/go/gobuild.vim +++ b/ale_linters/go/gobuild.vim @@ -1,4 +1,5 @@ -" Author: Joshua Rubin <joshua@rubixconsulting.com>, Ben Reedy <https://github.com/breed808> +" Author: Joshua Rubin <joshua@rubixconsulting.com>, Ben Reedy <https://github.com/breed808>, +" Jeff Willette <jrwillette88@gmail.com> " Description: go build for Go files " inspired by work from dzhou121 <dzhou121@gmail.com> @@ -39,15 +40,12 @@ function! ale_linters#go#gobuild#GetMatches(lines) abort endfunction function! ale_linters#go#gobuild#Handler(buffer, lines) abort + let l:dir = expand('#' . a:buffer . ':p:h') let l:output = [] for l:match in ale_linters#go#gobuild#GetMatches(a:lines) - " Omit errors from imported go packages - if !ale#path#IsBufferPath(a:buffer, l:match[1]) - continue - endif - call add(l:output, { + \ 'filename': ale#path#GetAbsPath(l:dir, l:match[1]), \ 'lnum': l:match[2] + 0, \ 'col': l:match[3] + 0, \ 'text': l:match[4], diff --git a/ale_linters/go/gometalinter.vim b/ale_linters/go/gometalinter.vim index f1abfc83..7f75c44e 100644 --- a/ale_linters/go/gometalinter.vim +++ b/ale_linters/go/gometalinter.vim @@ -1,4 +1,4 @@ -" Author: Ben Reedy <https://github.com/breed808> +" Author: Ben Reedy <https://github.com/breed808>, Jeff Willette <jrwillette88@gmail.com> " Description: Adds support for the gometalinter suite for Go files call ale#Set('go_gometalinter_options', '') @@ -14,7 +14,6 @@ function! ale_linters#go#gometalinter#GetCommand(buffer) abort let l:options = ale#Var(a:buffer, 'go_gometalinter_options') return ale#Escape(l:executable) - \ . ' --include=' . ale#Escape('^' . ale#util#EscapePCRE(l:filename)) \ . (!empty(l:options) ? ' ' . l:options : '') \ . ' ' . ale#Escape(fnamemodify(l:filename, ':h')) endfunction @@ -26,10 +25,12 @@ function! ale_linters#go#gometalinter#GetMatches(lines) abort endfunction function! ale_linters#go#gometalinter#Handler(buffer, lines) abort + let l:dir = expand('#' . a:buffer . ':p:h') let l:output = [] for l:match in ale_linters#go#gometalinter#GetMatches(a:lines) call add(l:output, { + \ 'filename': ale#path#GetAbsPath(l:dir, l:match[1]), \ 'lnum': l:match[2] + 0, \ 'col': l:match[3] + 0, \ 'type': tolower(l:match[4]) is# 'warning' ? 'W' : 'E', |