diff options
| author | w0rp <devw0rp@gmail.com> | 2017-05-15 20:43:55 +0100 |
|---|---|---|
| committer | w0rp <devw0rp@gmail.com> | 2017-05-15 20:43:55 +0100 |
| commit | 11a50b25807d7730adb42575d72f990fb8c32a7b (patch) | |
| tree | 90fc36f6278c7d1bad6d4b8d7034b2780c3700f3 | |
| parent | fa3a4b3ba2903e735fd3bbd761bec9ee3ea45e2b (diff) | |
| download | ale-11a50b25807d7730adb42575d72f990fb8c32a7b.zip | |
Fix #553 - Filter out errors from other files for gometalinter
| -rw-r--r-- | ale_linters/go/gometalinter.vim | 2 | ||||
| -rw-r--r-- | test/handler/test_gometalinter_handler.vader | 25 |
2 files changed, 24 insertions, 3 deletions
diff --git a/ale_linters/go/gometalinter.vim b/ale_linters/go/gometalinter.vim index aa524013..f47df6b9 100644 --- a/ale_linters/go/gometalinter.vim +++ b/ale_linters/go/gometalinter.vim @@ -22,7 +22,7 @@ function! ale_linters#go#gometalinter#Handler(buffer, lines) abort for l:match in ale_linters#go#gometalinter#GetMatches(a:lines) " Omit errors from files other than the one currently open - if ale#path#IsBufferPath(a:buffer, l:match[0]) + if !ale#path#IsBufferPath(a:buffer, l:match[1]) continue endif diff --git a/test/handler/test_gometalinter_handler.vader b/test/handler/test_gometalinter_handler.vader index 3b622130..52a4fc96 100644 --- a/test/handler/test_gometalinter_handler.vader +++ b/test/handler/test_gometalinter_handler.vader @@ -30,7 +30,7 @@ Execute (The gometalinter handler should handle names with spaces): \ ]), 'v:val[1:5]') Execute (The gometalinter handler should handle relative paths correctly): - :file! /foo/bar/baz.go + silent file /foo/bar/baz.go AssertEqual \ [ @@ -47,7 +47,28 @@ Execute (The gometalinter handler should handle relative paths correctly): \ 'type': 'E', \ }, \ ], - \ ale_linters#go#gometalinter#Handler(42, [ + \ ale_linters#go#gometalinter#Handler(bufnr(''), [ \ 'baz.go:12:3:warning: expected ''package'', found ''IDENT'' gibberish (staticcheck)', \ 'baz.go:37:5:error: expected ''package'', found ''IDENT'' gibberish (golint)', \ ]) + + +Execute (The gometalinter handler should filter out errors from other files): + silent file! /some/path/sql.go + + AssertEqual + \ [], + \ ale_linters#go#gometalinter#Handler(bufnr(''), [ + \ '/some/path/interface_implementation_test.go:417::warning: cyclomatic complexity 24 of function testGetUserHeaders() is high (> 10) (gocyclo)', + \ '/some/path/sql_helpers.go:38::warning: cyclomatic complexity 11 of function CreateTestUserMetadataDB() is high (> 10) (gocyclo)', + \ '/some/path/sql_alpha.go:560:7:warning: ineffectual assignment to err (ineffassign)', + \ '/some/path/sql_alpha.go:589:7:warning: ineffectual assignment to err (ineffassign)', + \ '/some/path/sql_test.go:124:9:warning: should not use basic type untyped string as key in context.WithValue (golint)', + \ '/some/path/interface_implementation_test.go:640::warning: declaration of "cfg" shadows declaration at sql_test.go:21 (vetshadow)', + \ '/some/path/sql_helpers.go:55::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)', + \ '/some/path/sql_helpers.go:91::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)', + \ '/some/path/sql_helpers.go:108::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)', + \ '/some/path/user_metadata_db.go:149::warning: declaration of "err" shadows declaration at user_metadata_db.go:140 (vetshadow)', + \ '/some/path/user_metadata_db.go:188::warning: declaration of "err" shadows declaration at user_metadata_db.go:179 (vetshadow)', + \ '/some/path/queries_alpha.go:62::warning: Potential hardcoded credentials,HIGH,LOW (gas)', + \ ]) |