diff options
| author | w0rp <devw0rp@gmail.com> | 2017-12-19 17:42:51 +0000 |
|---|---|---|
| committer | w0rp <devw0rp@gmail.com> | 2017-12-19 17:42:51 +0000 |
| commit | cc8e5502c8fd9d0d2ba405214e05f90b4152e2b2 (patch) | |
| tree | 1c6c9677aef120bf464dadda2645836230edc7ef | |
| parent | 0ad254799781ba1e00b13b26dfbee5c6fed9684f (diff) | |
| download | ale-cc8e5502c8fd9d0d2ba405214e05f90b4152e2b2.zip | |
Fix #1240 - Parse line and column numbers for fatal embertemplatelint errors
| -rw-r--r-- | ale_linters/handlebars/embertemplatelint.vim | 6 | ||||
| -rw-r--r-- | test/handler/test_embertemplatelint_handler.vader | 11 |
2 files changed, 6 insertions, 11 deletions
diff --git a/ale_linters/handlebars/embertemplatelint.vim b/ale_linters/handlebars/embertemplatelint.vim index 963ab568..68ea7155 100644 --- a/ale_linters/handlebars/embertemplatelint.vim +++ b/ale_linters/handlebars/embertemplatelint.vim @@ -22,15 +22,13 @@ function! ale_linters#handlebars#embertemplatelint#Handle(buffer, lines) abort for l:error in get(values(l:json), 0, []) if has_key(l:error, 'fatal') call add(l:output, { - \ 'bufnr': a:buffer, - \ 'lnum': 1, - \ 'col': 1, + \ 'lnum': get(l:error, 'line', 1), + \ 'col': get(l:error, 'column', 1), \ 'text': l:error.message, \ 'type': l:error.severity == 1 ? 'W' : 'E', \}) else call add(l:output, { - \ 'bufnr': a:buffer, \ 'lnum': l:error.line, \ 'col': l:error.column, \ 'text': l:error.rule . ': ' . l:error.message, diff --git a/test/handler/test_embertemplatelint_handler.vader b/test/handler/test_embertemplatelint_handler.vader index ea5313ca..97ca4390 100644 --- a/test/handler/test_embertemplatelint_handler.vader +++ b/test/handler/test_embertemplatelint_handler.vader @@ -32,14 +32,12 @@ Execute(The ember-template-lint handler should parse lines correctly): AssertEqual \ [ \ { - \ 'bufnr': 347, \ 'lnum': 1, \ 'col': 10, \ 'text': 'bare-strings: Non-translated string used', \ 'type': 'E', \ }, \ { - \ 'bufnr': 347, \ 'lnum': 3, \ 'col': 6, \ 'text': 'invalid-interactive: Interaction added to non-interactive element', @@ -55,8 +53,8 @@ Execute(The ember-template-lint handler should handle template parsing error cor \ "fatal": true, \ "moduleId": "app/templates/application", \ "message": "Parse error on line 5 ...", - \ "line": 1, - \ "column": 1, + \ "line": 5, + \ "column": 3, \ "source": "Error: Parse error on line 5 ...", \ "severity": 2 \ } @@ -66,9 +64,8 @@ Execute(The ember-template-lint handler should handle template parsing error cor AssertEqual \ [ \ { - \ 'bufnr': 347, - \ 'lnum': 1, - \ 'col': 1, + \ 'lnum': 5, + \ 'col': 3, \ 'text': 'Parse error on line 5 ...', \ 'type': 'E', \ }, |