summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Ouwens <jan.ouwens@gmail.com>2019-02-07 10:35:24 +0100
committerJan Ouwens <jan.ouwens@gmail.com>2019-02-07 11:20:18 +0100
commit5ce1e9b0b4c59457cdfb68be13216e162a6eab9e (patch)
tree9d6dd923c8f247042101cb2b92df93c7fa68a1fa
parent0b9c0c22009a991c16b08973025f9de9013838ed (diff)
downloadale-5ce1e9b0b4c59457cdfb68be13216e162a6eab9e.zip
Fixes javalsp linter
-rw-r--r--ale_linters/java/javalsp.vim4
-rw-r--r--doc/ale-java.txt25
-rw-r--r--test/command_callback/test_javalsp_command_callback.vader4
3 files changed, 14 insertions, 19 deletions
diff --git a/ale_linters/java/javalsp.vim b/ale_linters/java/javalsp.vim
index 1436a52c..6329ab3c 100644
--- a/ale_linters/java/javalsp.vim
+++ b/ale_linters/java/javalsp.vim
@@ -1,7 +1,6 @@
" Author: Horacio Sanson <https://github.com/hsanson>
" Description: Support for the Java language server https://github.com/georgewfraser/vscode-javac
-call ale#Set('java_javalsp_jar', 'javacs.jar')
call ale#Set('java_javalsp_executable', 'java')
function! ale_linters#java#javalsp#Executable(buffer) abort
@@ -9,10 +8,9 @@ function! ale_linters#java#javalsp#Executable(buffer) abort
endfunction
function! ale_linters#java#javalsp#Command(buffer) abort
- let l:jar = ale#Var(a:buffer, 'java_javalsp_jar')
let l:executable = ale_linters#java#javalsp#Executable(a:buffer)
- return ale#Escape(l:executable) . ' -cp ' . l:jar . ' -Xverify:none org.javacs.Main'
+ return ale#Escape(l:executable) . ' -Xverify:none -m javacs/org.javacs.Main'
endfunction
call ale#linter#Define('java', {
diff --git a/doc/ale-java.txt b/doc/ale-java.txt
index 8e40aea0..aa226305 100644
--- a/doc/ale-java.txt
+++ b/doc/ale-java.txt
@@ -79,14 +79,19 @@ g:ale_java_pmd_options *g:ale_java_pmd_options*
javalsp *ale-java-javalsp*
To enable Java LSP linter you need to download and build the vscode-javac
-language server from https://github.com/georgewfraser/vscode-javac. Simply
-download the source code and then build the plugin using maven:
+language server from https://github.com/georgewfraser/java-language-server.
+Simply download the source code and then build a distribution:
- mvn package
+ scripts/link_mac.sh
-This generates a out/fat-jar.jar file that contains the language server. To
-let ALE use this language server you need to set the g:ale_java_javalsp_jar
-variable to the absolute path of this jar file.
+or
+
+ scripts/link_windows.sh
+
+This generates a dist/mac or dist/windows directory that contains the
+language server. To let ALE use this language server you need to set the
+g:ale_java_javalsp_executable variable to the absolute path of the java
+executable in this directory.
g:ale_java_javalsp_executable *g:ale_java_javalsp_executable*
*b:ale_java_javalsp_executable*
@@ -95,14 +100,6 @@ g:ale_java_javalsp_executable *g:ale_java_javalsp_executable*
This variable can be changed to use a different executable for java.
-g:ale_java_javalsp_jar *g:ale_java_javalsp_jar*
- *b:ale_java_javalsp_jar*
-
- Type: |String|
- Default: `'fat-jar.jar'`
-
- Path to the location of the vscode-javac language server plugin.
-
===============================================================================
uncrustify *ale-java-uncrustify*
diff --git a/test/command_callback/test_javalsp_command_callback.vader b/test/command_callback/test_javalsp_command_callback.vader
index aedb4a4b..8bfaa8ee 100644
--- a/test/command_callback/test_javalsp_command_callback.vader
+++ b/test/command_callback/test_javalsp_command_callback.vader
@@ -6,9 +6,9 @@ After:
call ale#assert#TearDownLinterTest()
Execute(The javalsp callback should return the correct default value):
- AssertLinter 'java', ale#Escape('java') . ' -cp javacs.jar -Xverify:none org.javacs.Main'
+ AssertLinter 'java', ale#Escape('java') . ' -Xverify:none -m javacs/org.javacs.Main'
Execute(The javalsp java executable should be configurable):
let b:ale_java_javalsp_executable = '/bin/foobar'
- AssertLinter '/bin/foobar', ale#Escape('/bin/foobar') . ' -cp javacs.jar -Xverify:none org.javacs.Main'
+ AssertLinter '/bin/foobar', ale#Escape('/bin/foobar') . ' -Xverify:none -m javacs/org.javacs.Main'