diff options
| author | w0rp <w0rp@users.noreply.github.com> | 2017-11-20 20:58:43 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-11-20 20:58:43 +0000 |
| commit | 5a3a6955863fde86ef318a1fc6c3ad5d23429c0a (patch) | |
| tree | 7a9a4f6c7ad618041ca2a171eaa22db1aa201e0c | |
| parent | c9e203e6204314b55aed76c49f57aaf8ab826c90 (diff) | |
| parent | b9f02ffb275b1d120967ab163e79959d3673ffd6 (diff) | |
| download | ale-5a3a6955863fde86ef318a1fc6c3ad5d23429c0a.zip | |
Merge pull request #1154 from deltaskelta/add-filename-key-for-gobuild
Added filename key for `go build` linter
| -rw-r--r-- | ale_linters/go/gobuild.vim | 10 | ||||
| -rw-r--r-- | test/handler/test_gobuild_handler.vader | 5 |
2 files changed, 7 insertions, 8 deletions
diff --git a/ale_linters/go/gobuild.vim b/ale_linters/go/gobuild.vim index 143c2fd0..783b9e0a 100644 --- a/ale_linters/go/gobuild.vim +++ b/ale_linters/go/gobuild.vim @@ -1,4 +1,5 @@ -" Author: Joshua Rubin <joshua@rubixconsulting.com>, Ben Reedy <https://github.com/breed808> +" Author: Joshua Rubin <joshua@rubixconsulting.com>, Ben Reedy <https://github.com/breed808>, +" Jeff Willette <jrwillette88@gmail.com> " Description: go build for Go files " inspired by work from dzhou121 <dzhou121@gmail.com> @@ -39,15 +40,12 @@ function! ale_linters#go#gobuild#GetMatches(lines) abort endfunction function! ale_linters#go#gobuild#Handler(buffer, lines) abort + let l:dir = expand('#' . a:buffer . ':p:h') let l:output = [] for l:match in ale_linters#go#gobuild#GetMatches(a:lines) - " Omit errors from imported go packages - if !ale#path#IsBufferPath(a:buffer, l:match[1]) - continue - endif - call add(l:output, { + \ 'filename': ale#path#GetAbsPath(l:dir, l:match[1]), \ 'lnum': l:match[2] + 0, \ 'col': l:match[3] + 0, \ 'text': l:match[4], diff --git a/test/handler/test_gobuild_handler.vader b/test/handler/test_gobuild_handler.vader index ce2119cd..ec77f9c4 100644 --- a/test/handler/test_gobuild_handler.vader +++ b/test/handler/test_gobuild_handler.vader @@ -28,7 +28,7 @@ Execute (The gobuild handler should handle names with spaces): \ ]), 'v:val[1:4]') Execute (The gobuild handler should handle relative paths correctly): - silent file! /foo/bar/baz.go + call ale#test#SetFilename('app/test.go') AssertEqual \ [ @@ -37,8 +37,9 @@ Execute (The gobuild handler should handle relative paths correctly): \ 'col': 0, \ 'text': 'missing argument for Printf("%s"): format reads arg 2, have only 1 args', \ 'type': 'E', + \ 'filename': ale#path#Winify(expand('%:p:h') . '/test.go'), \ }, \ ], \ ale_linters#go#gobuild#Handler(bufnr(''), [ - \ 'baz.go:27: missing argument for Printf("%s"): format reads arg 2, have only 1 args', + \ 'test.go:27: missing argument for Printf("%s"): format reads arg 2, have only 1 args', \ ]) |