diff options
| author | w0rp <w0rp@users.noreply.github.com> | 2020-08-07 08:54:17 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-07 08:54:17 +0100 |
| commit | 667618b399d820865751ca7cc4e8fce344384510 (patch) | |
| tree | 4eb586ff134deeafb924e1bb9ea185f258a20fd9 | |
| parent | f17b74679ffef9658e1a67fa280fe233c80aa378 (diff) | |
| parent | 35c7c297b60ba8b8296ebccb6b1b09f8ab208de4 (diff) | |
| download | ale-667618b399d820865751ca7cc4e8fce344384510.zip | |
Merge pull request #3191 from mostfunkyduck/master
Fixes govet linter for go 1.13+, with tests
| -rw-r--r-- | autoload/ale/handlers/go.vim | 5 | ||||
| -rw-r--r-- | test/handler/test_go_generic_handler.vader | 16 |
2 files changed, 20 insertions, 1 deletions
diff --git a/autoload/ale/handlers/go.vim b/autoload/ale/handlers/go.vim index f17cd862..c969669d 100644 --- a/autoload/ale/handlers/go.vim +++ b/autoload/ale/handlers/go.vim @@ -6,9 +6,12 @@ " " Author: Ben Paxton <ben@gn32.uk> " Description: moved to generic Golang file from govet +" +" Author: mostfunkyduck <mostfunkyduck@protonmail.com> +" Description: updated to work with go 1.14 function! ale#handlers#go#Handler(buffer, lines) abort - let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?:? ?(.+)$' + let l:pattern = '\v^%(vet: )?([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?:? ?(.+)$' let l:output = [] let l:dir = expand('#' . a:buffer . ':p:h') diff --git a/test/handler/test_go_generic_handler.vader b/test/handler/test_go_generic_handler.vader index 624e56c1..2b17fdcb 100644 --- a/test/handler/test_go_generic_handler.vader +++ b/test/handler/test_go_generic_handler.vader @@ -15,8 +15,24 @@ Execute(The golang handler should return the correct filenames): \ 'type': 'E', \ 'filename': ale#path#Simplify(expand('%:p:h') . '/other.go'), \ }, + \ { + \ 'lnum': 18, + \ 'col': 0, + \ 'text': 'random error', + \ 'type': 'E', + \ 'filename': ale#path#Simplify(expand('%:p:h') . '/go1.14.go'), + \ }, + \ { + \ 'lnum': 36, + \ 'col': 2, + \ 'text': 'another random error', + \ 'type': 'E', + \ 'filename': ale#path#Simplify(expand('%:p:h') . '/anothergo1.14.go'), + \ }, \ ], \ ale#handlers#go#Handler(bufnr(''), [ \ 'test.go:27: some error', \ 'other.go:27:5: some error with a column', + \ 'vet: go1.14.go:18:0: random error', + \ 'vet: anothergo1.14.go:36:2: another random error', \ ]) |