From 4753cfd3e33f985ec22c5600a8d7e68b72175607 Mon Sep 17 00:00:00 2001
From: Tim Culverhouse <tim@timculverhouse.com>
Date: Fri, 10 Jun 2022 17:24:12 -0500
Subject: visual-mode: deselect messages after performing command

In order to better align to vim functionality: deselect visual mode
selections after performing a command on the selection. This patch also
introduces a new command to allow for re-selecting (remarking) the
previous selection set so that commands can be chained together. The
deselection only applies to msg commands that *do not* move the message
from the store (those types of commands already deselect):
- read/unread
- flag/unflag
- modify-labels
- copy
- pipe

Previous usage to mark several messages as read and deselect all:
Vjjj:read<Enter>:unmark -a<Enter>

New usage, similar to vim:
Vjjj:read<Enter>

To chain a command together:
Vjjj:read<Enter>:remark<Enter>{next command}<Enter>

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Acked-by: Robin Jarry <robin@jarry.cc>
---
 commands/msg/copy.go          | 1 +
 commands/msg/mark.go          | 8 +++++++-
 commands/msg/modify-labels.go | 1 +
 commands/msg/pipe.go          | 2 +-
 commands/msg/read.go          | 1 +
 5 files changed, 11 insertions(+), 2 deletions(-)

(limited to 'commands')

diff --git a/commands/msg/copy.go b/commands/msg/copy.go
index 3b3dd72..a68a22a 100644
--- a/commands/msg/copy.go
+++ b/commands/msg/copy.go
@@ -59,6 +59,7 @@ func (Copy) Execute(aerc *widgets.Aerc, args []string) error {
 			switch msg := msg.(type) {
 			case *types.Done:
 				aerc.PushStatus("Messages copied.", 10*time.Second)
+				store.ClearVisualMark()
 			case *types.Error:
 				aerc.PushError(msg.Error.Error())
 			}
diff --git a/commands/msg/mark.go b/commands/msg/mark.go
index d6beae4..c446fc6 100644
--- a/commands/msg/mark.go
+++ b/commands/msg/mark.go
@@ -14,7 +14,7 @@ func init() {
 }
 
 func (Mark) Aliases() []string {
-	return []string{"mark", "unmark"}
+	return []string{"mark", "unmark", "remark"}
 }
 
 func (Mark) Complete(aerc *widgets.Aerc, args []string) []string {
@@ -93,6 +93,12 @@ func (Mark) Execute(aerc *widgets.Aerc, args []string) error {
 			store.Unmark(selected.Uid)
 			return nil
 		}
+	case "remark":
+		if all || visual || toggle {
+			return fmt.Errorf("Usage: :remark")
+		}
+		store.Remark()
+		return nil
 	}
 	return nil // never reached
 }
diff --git a/commands/msg/modify-labels.go b/commands/msg/modify-labels.go
index ca3ccf7..a3b4900 100644
--- a/commands/msg/modify-labels.go
+++ b/commands/msg/modify-labels.go
@@ -57,6 +57,7 @@ func (ModifyLabels) Execute(aerc *widgets.Aerc, args []string) error {
 		switch msg := msg.(type) {
 		case *types.Done:
 			aerc.PushStatus("labels updated", 10*time.Second)
+			store.ClearVisualMark()
 		case *types.Error:
 			aerc.PushError(msg.Error.Error())
 		}
diff --git a/commands/msg/pipe.go b/commands/msg/pipe.go
index 06f2a4d..b33254d 100644
--- a/commands/msg/pipe.go
+++ b/commands/msg/pipe.go
@@ -197,7 +197,7 @@ func (Pipe) Execute(aerc *widgets.Aerc, args []string) error {
 			}
 		})
 	}
-
+	provider.Store().ClearVisualMark()
 	return nil
 }
 
diff --git a/commands/msg/read.go b/commands/msg/read.go
index 4f8880a..c6bcd0d 100644
--- a/commands/msg/read.go
+++ b/commands/msg/read.go
@@ -175,6 +175,7 @@ func (FlagMsg) Execute(aerc *widgets.Aerc, args []string) error {
 		wg.Wait()
 		if success {
 			aerc.PushStatus(actionName+" flag '"+flagName+"' successful", 10*time.Second)
+			store.ClearVisualMark()
 		}
 	}()
 
-- 
cgit v1.2.3