summaryrefslogtreecommitdiff
path: root/worker
diff options
context:
space:
mode:
authorMoritz Poldrack <git@moritz.sh>2022-03-22 09:52:27 +0100
committerRobin Jarry <robin@jarry.cc>2022-03-23 20:56:09 +0100
commitae83373fa63883f03bd5580ad3937d1e5fa428ed (patch)
tree12e7bae80292088f7dfed45279fa3bce225743bf /worker
parentfeecc09b73e2c904be42f271e0c10574b98a95ea (diff)
downloadaerc-ae83373fa63883f03bd5580ad3937d1e5fa428ed.zip
logging: added a log on panic
Since panics still regularly "destroy" the terminal, it is hard to get a stack trace for panics you do not anticipate. This commit adds a panic handler that automatically creates a logfile inside the current working directory. It has to be added to every goroutine that is started and will repair the terminal on a panic. Signed-off-by: Moritz Poldrack <git@moritz.sh> Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'worker')
-rw-r--r--worker/imap/fetch.go3
-rw-r--r--worker/imap/flags.go3
-rw-r--r--worker/imap/list.go3
-rw-r--r--worker/imap/worker.go3
-rw-r--r--worker/notmuch/worker.go3
5 files changed, 15 insertions, 0 deletions
diff --git a/worker/imap/fetch.go b/worker/imap/fetch.go
index 364fe57..2b816f4 100644
--- a/worker/imap/fetch.go
+++ b/worker/imap/fetch.go
@@ -10,6 +10,7 @@ import (
"github.com/emersion/go-message/mail"
"github.com/emersion/go-message/textproto"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/models"
"git.sr.ht/~rjarry/aerc/worker/types"
)
@@ -169,6 +170,8 @@ func (imapw *IMAPWorker) handleFetchMessages(
done := make(chan error)
go func() {
+ defer logging.PanicHandler()
+
var reterr error
for _msg := range messages {
imapw.seqMap[_msg.SeqNum-1] = _msg.Uid
diff --git a/worker/imap/flags.go b/worker/imap/flags.go
index cc8a8ce..22c23dd 100644
--- a/worker/imap/flags.go
+++ b/worker/imap/flags.go
@@ -4,6 +4,7 @@ import (
"fmt"
"github.com/emersion/go-imap"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/worker/types"
)
@@ -22,6 +23,8 @@ func (imapw *IMAPWorker) handleDeleteMessages(msg *types.DeleteMessages) {
ch := make(chan uint32)
done := make(chan interface{})
go func() {
+ defer logging.PanicHandler()
+
for seqNum := range ch {
i := seqNum - 1
deleted = append(deleted, imapw.seqMap[i])
diff --git a/worker/imap/list.go b/worker/imap/list.go
index 25c247a..026aa9a 100644
--- a/worker/imap/list.go
+++ b/worker/imap/list.go
@@ -3,6 +3,7 @@ package imap
import (
"github.com/emersion/go-imap"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/models"
"git.sr.ht/~rjarry/aerc/worker/types"
)
@@ -13,6 +14,8 @@ func (imapw *IMAPWorker) handleListDirectories(msg *types.ListDirectories) {
done := make(chan interface{})
go func() {
+ defer logging.PanicHandler()
+
for mbox := range mailboxes {
if !canOpen(mbox) {
// no need to pass this to handlers if it can't be opened
diff --git a/worker/imap/worker.go b/worker/imap/worker.go
index 6bc850c..2036ee1 100644
--- a/worker/imap/worker.go
+++ b/worker/imap/worker.go
@@ -17,6 +17,7 @@ import (
"golang.org/x/oauth2"
"git.sr.ht/~rjarry/aerc/lib"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/models"
"git.sr.ht/~rjarry/aerc/worker/handlers"
"git.sr.ht/~rjarry/aerc/worker/types"
@@ -83,6 +84,8 @@ func (w *IMAPWorker) handleMessage(msg types.WorkerMessage) error {
if w.client != nil && w.client.State() == imap.SelectedState {
w.idleStop = make(chan struct{})
go func() {
+ defer logging.PanicHandler()
+
w.idleDone <- w.client.Idle(w.idleStop, &client.IdleOptions{LogoutTimeout: 0, PollInterval: 0})
}()
}
diff --git a/worker/notmuch/worker.go b/worker/notmuch/worker.go
index 36ed2c8..4091ea4 100644
--- a/worker/notmuch/worker.go
+++ b/worker/notmuch/worker.go
@@ -16,6 +16,7 @@ import (
"git.sr.ht/~rjarry/aerc/config"
"git.sr.ht/~rjarry/aerc/lib/uidstore"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/models"
"git.sr.ht/~rjarry/aerc/worker/handlers"
"git.sr.ht/~rjarry/aerc/worker/lib"
@@ -180,6 +181,8 @@ func (w *worker) handleConnect(msg *types.Connect) error {
w.done(msg)
w.emitLabelList()
go func() {
+ defer logging.PanicHandler()
+
for {
w.nmEvents <- &updateDirCounts{}
time.Sleep(backgroundRefreshDelay)