summaryrefslogtreecommitdiff
path: root/commands/msgview
diff options
context:
space:
mode:
authorMoritz Poldrack <git@moritz.sh>2022-03-22 09:52:27 +0100
committerRobin Jarry <robin@jarry.cc>2022-03-23 20:56:09 +0100
commitae83373fa63883f03bd5580ad3937d1e5fa428ed (patch)
tree12e7bae80292088f7dfed45279fa3bce225743bf /commands/msgview
parentfeecc09b73e2c904be42f271e0c10574b98a95ea (diff)
downloadaerc-ae83373fa63883f03bd5580ad3937d1e5fa428ed.zip
logging: added a log on panic
Since panics still regularly "destroy" the terminal, it is hard to get a stack trace for panics you do not anticipate. This commit adds a panic handler that automatically creates a logfile inside the current working directory. It has to be added to every goroutine that is started and will repair the terminal on a panic. Signed-off-by: Moritz Poldrack <git@moritz.sh> Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'commands/msgview')
-rw-r--r--commands/msgview/open.go3
-rw-r--r--commands/msgview/save.go3
2 files changed, 6 insertions, 0 deletions
diff --git a/commands/msgview/open.go b/commands/msgview/open.go
index 5b19912..d8a4de0 100644
--- a/commands/msgview/open.go
+++ b/commands/msgview/open.go
@@ -9,6 +9,7 @@ import (
"time"
"git.sr.ht/~rjarry/aerc/lib"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/widgets"
)
@@ -66,6 +67,8 @@ func (Open) Execute(aerc *widgets.Aerc, args []string) error {
return
}
go func() {
+ defer logging.PanicHandler()
+
err := xdg.Wait()
if err != nil {
aerc.PushError(err.Error())
diff --git a/commands/msgview/save.go b/commands/msgview/save.go
index 26a6bf2..48add98 100644
--- a/commands/msgview/save.go
+++ b/commands/msgview/save.go
@@ -13,6 +13,7 @@ import (
"github.com/mitchellh/go-homedir"
"git.sr.ht/~rjarry/aerc/commands"
+ "git.sr.ht/~rjarry/aerc/logging"
"git.sr.ht/~rjarry/aerc/models"
"git.sr.ht/~rjarry/aerc/widgets"
)
@@ -126,6 +127,8 @@ func (Save) Execute(aerc *widgets.Aerc, args []string) error {
// we need to wait for the callback prior to displaying a result
go func() {
+ defer logging.PanicHandler()
+
err := <-ch
if err != nil {
aerc.PushError(fmt.Sprintf("Save failed: %v", err))