diff options
| author | Tim Culverhouse <tim@timculverhouse.com> | 2022-07-17 08:03:43 -0500 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-07-17 18:35:21 +0200 |
| commit | 04097e874388bf30e808a9a9993230c668a36ec4 (patch) | |
| tree | 5ebeade1166d16f0f2cbe99279c2264043e43844 | |
| parent | e92573c5d7161e7d7fdaaeab9a7ced0b03fa2277 (diff) | |
| download | aerc-04097e874388bf30e808a9a9993230c668a36ec4.zip | |
msgstore: do not build threads when threaded view is off
Commit 3a614e45fce9 ("threading: enable toggle-threads for server-side
threads") changed the behavior of the msgstore.buildThreads variable to
reflect whether the client needs to build threads or the server will.
However, a call to runThreadbuilder was not updated with an extra
conditional. As a result, threads were built regardless of the state of
the threadedView resulting in a large performance penalty for
non-threaded views with client side threading.
Only run thread builder if threaded view is enabled.
Fixes: 3a614e45fce9 ("threading: enable toggle-threads for server-side threads")
Reported-by: akspecs <akspecs@gmail.com>
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Acked-by: Akspecs <akspecs@gmail.com>
Acked-by: Robin Jarry <robin@jarry.cc>
| -rw-r--r-- | lib/msgstore.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/msgstore.go b/lib/msgstore.go index a54b20b..240d4b7 100644 --- a/lib/msgstore.go +++ b/lib/msgstore.go @@ -356,7 +356,7 @@ func (store *MessageStore) update() { if store.onUpdateDirs != nil { store.onUpdateDirs() } - if store.BuildThreads() { + if store.BuildThreads() && store.ThreadedView() { store.runThreadBuilder() } } |