From e578f4ca93f6292f62e4b4c7fa11d17fe0b27c71 Mon Sep 17 00:00:00 2001
From: ByteHamster <ByteHamster@users.noreply.github.com>
Date: Sun, 7 Apr 2024 23:28:14 +0200
Subject: CI tweaks (#7069)

- Run Checkstyle with gradle to make it easier for users
  - No longer needs different configuration for new code
  - Exclude current violations
  - Fix some violations that somehow couldn't be specified in the exclusion file
- Print SpotBugs/Lint/Checkstly violations in GitHub format
  - Then the CI run gets annotated on the web UI
---
 .../src/main/res/layout/statistics_fragment.xml    |  35 +++---
 .../src/main/res/layout/statistics_listitem.xml    | 121 +++++++++++----------
 2 files changed, 79 insertions(+), 77 deletions(-)

(limited to 'ui/statistics')

diff --git a/ui/statistics/src/main/res/layout/statistics_fragment.xml b/ui/statistics/src/main/res/layout/statistics_fragment.xml
index 9d9cad438..1299884b6 100644
--- a/ui/statistics/src/main/res/layout/statistics_fragment.xml
+++ b/ui/statistics/src/main/res/layout/statistics_fragment.xml
@@ -1,24 +1,25 @@
 <?xml version="1.0" encoding="utf-8"?>
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
-              xmlns:tools="http://schemas.android.com/tools"
-              android:layout_width="match_parent"
-              android:layout_height="match_parent"
-              android:orientation="vertical">
+<FrameLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:orientation="vertical">
 
     <ProgressBar
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:id="@+id/progressBar"
-            android:layout_gravity="center"/>
+        android:id="@+id/progressBar"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center" />
 
     <androidx.recyclerview.widget.RecyclerView
-            android:id="@+id/statistics_list"
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:clipToPadding="false"
-            android:paddingBottom="@dimen/list_vertical_padding"
-            android:paddingTop="@dimen/list_vertical_padding"
-            android:scrollbarStyle="outsideOverlay"
-            tools:listitem="@layout/statistics_listitem"/>
+        android:id="@+id/statistics_list"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:clipToPadding="false"
+        android:paddingBottom="@dimen/list_vertical_padding"
+        android:paddingTop="@dimen/list_vertical_padding"
+        android:scrollbarStyle="outsideOverlay"
+        tools:listitem="@layout/statistics_listitem" />
 
 </FrameLayout>
diff --git a/ui/statistics/src/main/res/layout/statistics_listitem.xml b/ui/statistics/src/main/res/layout/statistics_listitem.xml
index 5989595e1..803324e85 100644
--- a/ui/statistics/src/main/res/layout/statistics_listitem.xml
+++ b/ui/statistics/src/main/res/layout/statistics_listitem.xml
@@ -1,71 +1,72 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
-                xmlns:tools="http://schemas.android.com/tools"
-                android:orientation="vertical"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:paddingLeft="16dp"
-                android:paddingRight="16dp"
-                android:paddingTop="8dp"
-                android:paddingBottom="8dp"
-                android:background="?android:attr/selectableItemBackground">
+<RelativeLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:paddingLeft="16dp"
+    android:paddingRight="16dp"
+    android:paddingTop="8dp"
+    android:paddingBottom="8dp"
+    android:background="?android:attr/selectableItemBackground">
 
     <ImageView
-            android:id="@+id/imgvCover"
-            android:importantForAccessibility="no"
-            android:layout_width="40dp"
-            android:layout_height="40dp"
-            android:layout_alignParentLeft="true"
-            android:layout_alignParentStart="true"
-            android:layout_centerVertical="true"
-            android:adjustViewBounds="true"
-            android:cropToPadding="true"
-            android:scaleType="fitCenter"
-            tools:src="@tools:sample/avatars"
-            tools:background="@android:color/holo_green_dark"/>
+        android:id="@+id/imgvCover"
+        android:layout_width="40dp"
+        android:layout_height="40dp"
+        android:importantForAccessibility="no"
+        android:layout_alignParentLeft="true"
+        android:layout_alignParentStart="true"
+        android:layout_centerVertical="true"
+        android:adjustViewBounds="true"
+        android:cropToPadding="true"
+        android:scaleType="fitCenter"
+        tools:src="@tools:sample/avatars"
+        tools:background="@android:color/holo_green_dark" />
 
     <TextView
-            android:id="@+id/txtvTitle"
-            android:lines="1"
-            android:ellipsize="end"
-            android:singleLine="true"
-            android:textColor="?android:attr/textColorPrimary"
-            android:textSize="16sp"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_marginLeft="16dp"
-            android:layout_marginStart="16dp"
-            android:layout_toRightOf="@id/imgvCover"
-            android:layout_toEndOf="@id/imgvCover"
-            android:layout_alignTop="@id/imgvCover"
-            android:layout_alignWithParentIfMissing="true"
-            tools:text="Feed title"/>
+        android:id="@+id/txtvTitle"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:lines="1"
+        android:ellipsize="end"
+        android:singleLine="true"
+        android:textColor="?android:attr/textColorPrimary"
+        android:textSize="16sp"
+        android:layout_marginLeft="16dp"
+        android:layout_marginStart="16dp"
+        android:layout_toRightOf="@id/imgvCover"
+        android:layout_toEndOf="@id/imgvCover"
+        android:layout_alignTop="@id/imgvCover"
+        android:layout_alignWithParentIfMissing="true"
+        tools:text="Feed title" />
 
     <TextView
-            android:id="@+id/chip"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:textSize="13sp"
-            android:layout_toEndOf="@+id/imgvCover"
-            android:layout_toRightOf="@+id/imgvCover"
-            android:layout_marginLeft="16dp"
-            android:layout_marginStart="16dp"
-            android:layout_below="@+id/txtvTitle"
-            android:layout_marginEnd="4dp"
-            android:layout_marginRight="4dp"
-            android:text="⬤"
-            tools:ignore="HardcodedText"/>
+        android:id="@+id/chip"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:textSize="13sp"
+        android:layout_toEndOf="@+id/imgvCover"
+        android:layout_toRightOf="@+id/imgvCover"
+        android:layout_marginLeft="16dp"
+        android:layout_marginStart="16dp"
+        android:layout_below="@+id/txtvTitle"
+        android:layout_marginEnd="4dp"
+        android:layout_marginRight="4dp"
+        android:text="⬤"
+        tools:ignore="HardcodedText" />
 
     <TextView
-            android:id="@+id/txtvValue"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:lines="1"
-            android:textColor="?android:attr/textColorTertiary"
-            android:textSize="14sp"
-            android:layout_toEndOf="@+id/chip"
-            android:layout_toRightOf="@+id/chip"
-            android:layout_below="@+id/txtvTitle"
-            tools:text="23 hours"/>
+        android:id="@+id/txtvValue"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:lines="1"
+        android:textColor="?android:attr/textColorTertiary"
+        android:textSize="14sp"
+        android:layout_toEndOf="@+id/chip"
+        android:layout_toRightOf="@+id/chip"
+        android:layout_below="@+id/txtvTitle"
+        tools:text="23 hours" />
 
 </RelativeLayout>
-- 
cgit v1.2.3