From 844b54f26d6d9dbe33791957acc7f827a3644e4c Mon Sep 17 00:00:00 2001
From: Martin Fietz <Martin.Fietz@gmail.com>
Date: Sat, 3 Oct 2015 18:20:59 +0200
Subject: Drawer: Sort feeds by most recent publication date

---
 .../antennapod/core/preferences/UserPreferences.java    |  1 +
 .../de/danoeh/antennapod/core/storage/DBReader.java     | 17 ++++++++++++++++-
 core/src/main/res/values/arrays.xml                     |  2 ++
 core/src/main/res/values/strings.xml                    |  1 +
 4 files changed, 20 insertions(+), 1 deletion(-)

(limited to 'core')

diff --git a/core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java b/core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
index c0e53842f..59f8e29e1 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
@@ -98,6 +98,7 @@ public class UserPreferences {
     private static int EPISODE_CACHE_SIZE_UNLIMITED = -1;
     public static int FEED_ORDER_COUNTER = 0;
     public static int FEED_ORDER_ALPHABETICAL = 1;
+    public static int FEED_ORDER_LAST_UPDATE = 2;
     public static int FEED_COUNTER_SHOW_NEW_UNPLAYED_SUM = 0;
     public static int FEED_COUNTER_SHOW_NEW = 1;
     public static int FEED_COUNTER_SHOW_UNPLAYED = 2;
diff --git a/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java b/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
index d95e4ff02..061ce0634 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
@@ -8,6 +8,7 @@ import org.apache.commons.lang3.StringUtils;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.Date;
 import java.util.List;
 
 import de.danoeh.antennapod.core.feed.Chapter;
@@ -947,13 +948,27 @@ public final class DBReader {
                     return 1;
                 }
             };
-        } else {
+        } else if(feedOrder == UserPreferences.FEED_ORDER_ALPHABETICAL) {
             comparator = (lhs, rhs) -> {
                 if(lhs.getTitle() == null) {
                     return 1;
                 }
                 return lhs.getTitle().compareTo(rhs.getTitle());
             };
+        } else {
+            comparator = (lhs, rhs) -> {
+                if(lhs.getItems() == null || lhs.getItems().size() == 0) {
+                    List<FeedItem> items = DBReader.getFeedItemList(lhs);
+                    lhs.setItems(items);
+                }
+                if(rhs.getItems() == null || rhs.getItems().size() == 0) {
+                    List<FeedItem> items = DBReader.getFeedItemList(rhs);
+                    rhs.setItems(items);
+                }
+                Date d1 = lhs.getMostRecentItem().getPubDate();
+                Date d2 = rhs.getMostRecentItem().getPubDate();
+                return d2.compareTo(d1);
+            };
         }
 
         Collections.sort(feeds, comparator);
diff --git a/core/src/main/res/values/arrays.xml b/core/src/main/res/values/arrays.xml
index 20eb79f84..727b2e35a 100644
--- a/core/src/main/res/values/arrays.xml
+++ b/core/src/main/res/values/arrays.xml
@@ -129,10 +129,12 @@
     <string-array name="nav_drawer_feed_order_options">
         <item>@string/drawer_feed_order_unplayed_episodes</item>
         <item>@string/drawer_feed_order_alphabetical</item>
+        <item>@string/drawer_feed_order_last_update</item>
     </string-array>
     <string-array name="nav_drawer_feed_order_values">
         <item>0</item>
         <item>1</item>
+        <item>2</item>
     </string-array>
 
     <string-array name="nav_drawer_feed_counter_options">
diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml
index ae1381de3..34f3791c4 100644
--- a/core/src/main/res/values/strings.xml
+++ b/core/src/main/res/values/strings.xml
@@ -36,6 +36,7 @@
     <string name="drawer_preferences">Drawer Preferences</string>
     <string name="drawer_feed_order_unplayed_episodes">Sort by counter</string>
     <string name="drawer_feed_order_alphabetical">Sort alphabetically</string>
+    <string name="drawer_feed_order_last_update">Sort by publication date</string>
     <string name="drawer_feed_counter_new_unplayed">Number of new and unplayed episodes</string>
     <string name="drawer_feed_counter_new">Number of new episodes</string>
     <string name="drawer_feed_counter_unplayed">Number of unplayed episodes</string>
-- 
cgit v1.2.3


From 91cc0b2527573bc653e8d15b6d4b8f16ae31937f Mon Sep 17 00:00:00 2001
From: Martin Fietz <Martin.Fietz@gmail.com>
Date: Sun, 4 Oct 2015 10:28:32 +0200
Subject: Take feeds with no items into account

---
 .../java/de/danoeh/antennapod/core/storage/DBReader.java     | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'core')

diff --git a/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java b/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
index 061ce0634..7a8609b04 100644
--- a/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
+++ b/core/src/main/java/de/danoeh/antennapod/core/storage/DBReader.java
@@ -965,9 +965,15 @@ public final class DBReader {
                     List<FeedItem> items = DBReader.getFeedItemList(rhs);
                     rhs.setItems(items);
                 }
-                Date d1 = lhs.getMostRecentItem().getPubDate();
-                Date d2 = rhs.getMostRecentItem().getPubDate();
-                return d2.compareTo(d1);
+                if(lhs.getMostRecentItem() == null) {
+                    return 1;
+                } else if(rhs.getMostRecentItem() == null) {
+                    return -1;
+                } else {
+                    Date d1 = lhs.getMostRecentItem().getPubDate();
+                    Date d2 = rhs.getMostRecentItem().getPubDate();
+                    return d2.compareTo(d1);
+                }
             };
         }
 
-- 
cgit v1.2.3