From 118d9103c124700d82f5f50e2b8a7b2b8a5cb4ad Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Sat, 20 Jan 2018 18:26:08 -0800 Subject: Make some inner classes static This avoids an implicit this field and can help GC. Found via error-prone. --- .../de/danoeh/antennapod/core/service/download/DownloadService.java | 2 +- .../java/de/danoeh/antennapod/core/service/download/HttpDownloader.java | 2 +- .../de/danoeh/antennapod/core/util/syndication/HtmlToPlainText.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'core/src/main/java') diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java index f3cc8f86a..cd5cba981 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java @@ -950,7 +950,7 @@ public class DownloadService extends Service { *

* Currently, this handler only handles FeedMedia objects, because Feeds and FeedImages are deleted if the download fails. */ - private class FailedDownloadHandler implements Runnable { + private static class FailedDownloadHandler implements Runnable { private DownloadRequest request; private DownloadStatus status; diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/download/HttpDownloader.java b/core/src/main/java/de/danoeh/antennapod/core/service/download/HttpDownloader.java index b409a419a..77d664b74 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/download/HttpDownloader.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/download/HttpDownloader.java @@ -314,7 +314,7 @@ public class HttpDownloader extends Downloader { } } - private class BasicAuthorizationInterceptor implements Interceptor { + private static class BasicAuthorizationInterceptor implements Interceptor { private DownloadRequest downloadRequest; diff --git a/core/src/main/java/de/danoeh/antennapod/core/util/syndication/HtmlToPlainText.java b/core/src/main/java/de/danoeh/antennapod/core/util/syndication/HtmlToPlainText.java index bd40f398d..c497bfb4f 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/util/syndication/HtmlToPlainText.java +++ b/core/src/main/java/de/danoeh/antennapod/core/util/syndication/HtmlToPlainText.java @@ -40,7 +40,7 @@ public class HtmlToPlainText { } // the formatting rules, implemented in a breadth-first DOM traverse - private class FormattingVisitor implements NodeVisitor { + private static class FormattingVisitor implements NodeVisitor { private StringBuilder accum = new StringBuilder(); // holds the accumulated text -- cgit v1.2.3