From c2ccc28b9513dab91e006681fd0c8fafac275623 Mon Sep 17 00:00:00 2001
From: TacoTheDank <SkytkRSfan3895@gmail.com>
Date: Wed, 6 Mar 2024 02:52:14 -0500
Subject: Update SpotBugs

---
 config/spotbugs/exclude.xml | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

(limited to 'config/spotbugs/exclude.xml')

diff --git a/config/spotbugs/exclude.xml b/config/spotbugs/exclude.xml
index d544e86d9..7802c7c74 100644
--- a/config/spotbugs/exclude.xml
+++ b/config/spotbugs/exclude.xml
@@ -8,14 +8,30 @@
         <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
         <Class name="de.danoeh.antennapod.net.ssl.NoV1SslSocketFactory"/>
     </Match>
+    <Match>
+        <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
+        <Class name="de.danoeh.antennapod.ui.statistics.StatisticsFragment"/>
+    </Match>
     <Match>
         <Bug pattern="DM_DEFAULT_ENCODING"/>
         <Class name="de.danoeh.antennapod.parser.media.vorbis.VorbisCommentReader"/>
     </Match>
+    <Match>
+        <Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS"/>
+        <Class name="de.danoeh.antennapod.model.feed.FeedMedia"/>
+    </Match>
+    <Match>
+        <Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS"/>
+        <Class name="de.danoeh.antennapod.model.playback.RemoteMedia"/>
+    </Match>
     <Match>
         <Bug pattern="HSC_HUGE_SHARED_STRING_CONSTANT"/>
         <Class name="de.danoeh.antennapod.net.ssl.BackportCaCerts"/>
     </Match>
+    <Match>
+        <Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE"/>
+        <Class name="de.danoeh.antennapod.ui.echo.screens.RotatingSquaresScreen"/>
+    </Match>
     <Match>
         <Bug pattern="MS_CANNOT_BE_FINAL"/>
         <Class name="de.danoeh.antennapod.core.service.playback.PlaybackService"/>
@@ -44,6 +60,10 @@
         <Bug pattern="NP_NULL_PARAM_DEREF"/>
         <Class name="de.danoeh.antennapod.model.feed.FeedMedia"/>
     </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+        <Class name="de.danoeh.antennapod.core.service.download.DownloadRequestCreator"/>
+    </Match>
     <Match>
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
         <Class name="de.danoeh.antennapod.preferences.PreferenceUpgrader"/>
@@ -64,6 +84,22 @@
         <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
         <Class name="de.danoeh.antennapod.core.service.playback.PlaybackService"/>
     </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+        <Class name="de.danoeh.antennapod.ui.home.sections.EpisodesSurpriseSection"/>
+    </Match>
+    <Match>
+        <Bug pattern="URF_UNREAD_FIELD"/>
+        <Class name="de.danoeh.antennapod.ui.common.TriangleLabelView$PaintHolder"/>
+    </Match>
+    <Match>
+        <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+        <Class name="de.danoeh.antennapod.playback.base.PlaybackServiceMediaPlayer"/>
+    </Match>
+    <Match>
+        <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+        <Class name="de.danoeh.antennapod.playback.base.PlaybackServiceMediaPlayer$PSMPInfo"/>
+    </Match>
     <Match>
         <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/>
         <Class name="de.danoeh.antennapod.core.storage.NavDrawerData$TagDrawerItem"/>
@@ -77,10 +113,16 @@
 
     <Match><Package name="de.danoeh.antennapod.core.glide"/></Match>
     <Match><Package name="de.danoeh.antennapod.databinding"/></Match>
+    <Match><Package name="de.danoeh.antennapod.core.databinding"/></Match>
+    <Match><Package name="de.danoeh.antennapod.ui.common.databinding"/></Match>
+    <Match><Package name="de.danoeh.antennapod.ui.echo.databinding"/></Match>
+    <Match><Package name="de.danoeh.antennapod.ui.statistics.databinding"/></Match>
 
+    <Match><Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/></Match>
     <Match><Bug pattern="EI_EXPOSE_REP"/></Match>
     <Match><Bug pattern="EI_EXPOSE_REP2"/></Match>
     <Match><Bug pattern="HE_EQUALS_NO_HASHCODE"/></Match>
+    <Match><Bug pattern="HE_EQUALS_USE_HASHCODE"/></Match>
     <Match><Bug pattern="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG"/></Match>
     <Match><Bug pattern="IS2_INCONSISTENT_SYNC"/></Match>
     <Match><Bug pattern="NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION"/></Match>
@@ -96,6 +138,8 @@
     <Match><Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED"/></Match>
     <Match><Bug pattern="SF_SWITCH_NO_DEFAULT"/></Match>
     <Match><Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/></Match>
+    <Match><Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/></Match>
     <Match><Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/></Match>
+    <Match><Bug pattern="VA_FORMAT_STRING_USES_NEWLINE"/></Match>
     <Match><Bug pattern="WMI_WRONG_MAP_ITERATOR"/></Match>
 </FindBugsFilter>
-- 
cgit v1.2.3


From 522288260cc613f400488168b9ca27f29da42ebd Mon Sep 17 00:00:00 2001
From: TacoTheDank <SkytkRSfan3895@gmail.com>
Date: Wed, 6 Mar 2024 02:55:01 -0500
Subject: Clean up some old SpotBugs rules

---
 config/spotbugs/exclude.xml | 33 ---------------------------------
 1 file changed, 33 deletions(-)

(limited to 'config/spotbugs/exclude.xml')

diff --git a/config/spotbugs/exclude.xml b/config/spotbugs/exclude.xml
index 7802c7c74..b80c0550c 100644
--- a/config/spotbugs/exclude.xml
+++ b/config/spotbugs/exclude.xml
@@ -4,10 +4,6 @@
         <Bug pattern="BC_UNCONFIRMED_CAST"/>
         <Class name="de.danoeh.antennapod.adapter.NavListAdapter"/>
     </Match>
-    <Match>
-        <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
-        <Class name="de.danoeh.antennapod.net.ssl.NoV1SslSocketFactory"/>
-    </Match>
     <Match>
         <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
         <Class name="de.danoeh.antennapod.ui.statistics.StatisticsFragment"/>
@@ -40,10 +36,6 @@
         <Bug pattern="MS_MUTABLE_ARRAY"/>
         <Class name="de.danoeh.antennapod.fragment.NavDrawerFragment"/>
     </Match>
-    <Match>
-        <Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS"/>
-        <Class name="de.danoeh.antennapod.menuhandler.MenuItemUtils"/>
-    </Match>
     <Match>
         <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/>
         <Class name="de.danoeh.antennapod.activity.MainActivity"/>
@@ -56,10 +48,6 @@
         <Bug pattern="NP_NULL_ON_SOME_PATH"/>
         <Class name="de.danoeh.antennapod.model.feed.FeedMedia"/>
     </Match>
-    <Match>
-        <Bug pattern="NP_NULL_PARAM_DEREF"/>
-        <Class name="de.danoeh.antennapod.model.feed.FeedMedia"/>
-    </Match>
     <Match>
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
         <Class name="de.danoeh.antennapod.core.service.download.DownloadRequestCreator"/>
@@ -68,18 +56,6 @@
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
         <Class name="de.danoeh.antennapod.preferences.PreferenceUpgrader"/>
     </Match>
-    <Match>
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Class name="de.danoeh.antennapod.PodcastApp"/>
-    </Match>
-    <Match>
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Class name="de.danoeh.antennapod.core.service.download.DownloadService"/>
-    </Match>
-    <Match>
-        <Bug pattern="MS_CANNOT_BE_FINAL"/>
-        <Class name="de.danoeh.antennapod.core.service.download.DownloadService"/>
-    </Match>
     <Match>
         <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
         <Class name="de.danoeh.antennapod.core.service.playback.PlaybackService"/>
@@ -100,18 +76,9 @@
         <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
         <Class name="de.danoeh.antennapod.playback.base.PlaybackServiceMediaPlayer$PSMPInfo"/>
     </Match>
-    <Match>
-        <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/>
-        <Class name="de.danoeh.antennapod.core.storage.NavDrawerData$TagDrawerItem"/>
-    </Match>
-    <Match>
-        <Bug pattern="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
-        <Class name="de.danoeh.antennapod.core.cast.CastButtonVisibilityManager"/>
-    </Match>
 
     <Match><Class name="de.danoeh.antennapod.core.ClientConfig"/></Match>
 
-    <Match><Package name="de.danoeh.antennapod.core.glide"/></Match>
     <Match><Package name="de.danoeh.antennapod.databinding"/></Match>
     <Match><Package name="de.danoeh.antennapod.core.databinding"/></Match>
     <Match><Package name="de.danoeh.antennapod.ui.common.databinding"/></Match>
-- 
cgit v1.2.3