From 4c7531d277bf4b2a733031b9b1d3a7e9c1ad0241 Mon Sep 17 00:00:00 2001 From: orionlee Date: Wed, 2 May 2018 13:53:56 -0700 Subject: Flatten nested ifs, per @ByteHamster feedback --- .../antennapod/activity/MediaplayerActivity.java | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'app/src/main/java/de') diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java index 229848753..35f9579df 100644 --- a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java +++ b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java @@ -605,16 +605,14 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements } private static String getWebsiteLinkWithFallback(Playable media) { - String link = null; - if (media != null) { - link = media.getWebsiteLink(); - if (link == null) { - if (media instanceof FeedMedia) { - link = FeedItemUtil.getLinkWithFallback(((FeedMedia)media).getItem()); - } // else case not a FeedMedia, return null - } - } // else no media, return null - return link; + if (media == null) { + return null; + } else if (media.getWebsiteLink() != null) { + return media.getWebsiteLink(); + } else if (media instanceof FeedMedia) { + return FeedItemUtil.getLinkWithFallback(((FeedMedia)media).getItem()); + } + return null; } @Override -- cgit v1.2.3