From 4e185f2895d773ae3a966597ab8cc65e4d1c576d Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Thu, 29 Jul 2021 21:37:34 +0200 Subject: Removed left/right volume controls The setting does not work in our default player anyway and just clutters the interface with yet another setting that nobody uses. --- .../antennapod/dialog/PlaybackControlsDialog.java | 49 +--------------------- 1 file changed, 1 insertion(+), 48 deletions(-) (limited to 'app/src/main/java/de/danoeh') diff --git a/app/src/main/java/de/danoeh/antennapod/dialog/PlaybackControlsDialog.java b/app/src/main/java/de/danoeh/antennapod/dialog/PlaybackControlsDialog.java index 195891499..3186cbe2e 100644 --- a/app/src/main/java/de/danoeh/antennapod/dialog/PlaybackControlsDialog.java +++ b/app/src/main/java/de/danoeh/antennapod/dialog/PlaybackControlsDialog.java @@ -10,11 +10,9 @@ import androidx.appcompat.app.AlertDialog; import androidx.fragment.app.DialogFragment; import android.widget.Button; import android.widget.CheckBox; -import android.widget.SeekBar; import android.widget.TextView; import de.danoeh.antennapod.R; import de.danoeh.antennapod.core.preferences.UserPreferences; -import de.danoeh.antennapod.core.util.Converter; import de.danoeh.antennapod.core.util.playback.PlaybackController; import de.danoeh.antennapod.view.PlaybackSpeedSeekBar; @@ -63,11 +61,7 @@ public class PlaybackControlsDialog extends DialogFragment { dialog = new AlertDialog.Builder(getContext()) .setTitle(R.string.audio_controls) .setView(R.layout.audio_controls) - .setPositiveButton(R.string.close_label, (dialog1, which) -> { - final SeekBar left = dialog.findViewById(R.id.volume_left); - final SeekBar right = dialog.findViewById(R.id.volume_right); - UserPreferences.setVolume(left.getProgress(), right.getProgress()); - }).create(); + .setPositiveButton(R.string.close_label, null).create(); return dialog; } @@ -79,10 +73,6 @@ public class PlaybackControlsDialog extends DialogFragment { speedSeekBar.setProgressChangedListener(speed -> txtvPlaybackSpeed.setText(String.format(Locale.getDefault(), "%.2fx", speed))); - final SeekBar barLeftVolume = dialog.findViewById(R.id.volume_left); - barLeftVolume.setProgress(UserPreferences.getLeftVolumePercentage()); - final SeekBar barRightVolume = dialog.findViewById(R.id.volume_right); - barRightVolume.setProgress(UserPreferences.getRightVolumePercentage()); final CheckBox stereoToMono = dialog.findViewById(R.id.stereo_to_mono); stereoToMono.setChecked(UserPreferences.stereoToMono()); if (controller != null && !controller.canDownmix()) { @@ -91,10 +81,6 @@ public class PlaybackControlsDialog extends DialogFragment { stereoToMono.setText(getString(R.string.stereo_to_mono) + " [" + sonicOnly + "]"); } - if (UserPreferences.useExoplayer()) { - barRightVolume.setEnabled(false); - } - final CheckBox skipSilence = dialog.findViewById(R.id.skipSilence); skipSilence.setChecked(UserPreferences.isSkipSilence()); if (!UserPreferences.useExoplayer()) { @@ -106,39 +92,6 @@ public class PlaybackControlsDialog extends DialogFragment { UserPreferences.setSkipSilence(isChecked); controller.setSkipSilence(isChecked); }); - - barLeftVolume.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() { - @Override - public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) { - controller.setVolume( - Converter.getVolumeFromPercentage(progress), - Converter.getVolumeFromPercentage(barRightVolume.getProgress())); - } - - @Override - public void onStartTrackingTouch(SeekBar seekBar) { - } - - @Override - public void onStopTrackingTouch(SeekBar seekBar) { - } - }); - barRightVolume.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() { - @Override - public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) { - controller.setVolume( - Converter.getVolumeFromPercentage(barLeftVolume.getProgress()), - Converter.getVolumeFromPercentage(progress)); - } - - @Override - public void onStartTrackingTouch(SeekBar seekBar) { - } - - @Override - public void onStopTrackingTouch(SeekBar seekBar) { - } - }); stereoToMono.setOnCheckedChangeListener((buttonView, isChecked) -> { UserPreferences.stereoToMono(isChecked); if (controller != null) { -- cgit v1.2.3