From a252191d79f09c0f06cf13a700dd48dfdefd3fe4 Mon Sep 17 00:00:00 2001
From: Domingos Lopes <domingos86lopes@gmail.com>
Date: Tue, 22 Mar 2016 02:07:26 -0400
Subject: code cleaning:

- lambda expressions, method references,
- multi catches,
- remove unnecessary keywords (public keyword on interface method signatures, static on interfaces or enums, final on private method signatures),
- == false expressions,
- diamond type (<>) expressions,
- replace StringBuffer with StringBuilder for local variables used by a single thread,
- replace Arrays.asList with Collections.singletonList whenever applicable,
- inline variable returns (whenever the variable name's meaning is not important to understand the code),
- replace some chains of if/else if/... with switch/case,
- break append(a + b) into append(a).append(b) for StringBuilder objects,
- unused import statements,
- reduce log TAGs to 23 characters,
- MaterialDialog callback deprecated,
- ActionBarActivity for AppCompatActivity,
---
 .../preferences/PreferenceController.java          | 35 ++++++++++------------
 1 file changed, 16 insertions(+), 19 deletions(-)

(limited to 'app/src/main/java/de/danoeh/antennapod/preferences/PreferenceController.java')

diff --git a/app/src/main/java/de/danoeh/antennapod/preferences/PreferenceController.java b/app/src/main/java/de/danoeh/antennapod/preferences/PreferenceController.java
index d8d263313..6a85f7341 100644
--- a/app/src/main/java/de/danoeh/antennapod/preferences/PreferenceController.java
+++ b/app/src/main/java/de/danoeh/antennapod/preferences/PreferenceController.java
@@ -184,20 +184,17 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
         );
         ui.findPreference(PreferenceController.PREF_CHOOSE_DATA_DIR)
                 .setOnPreferenceClickListener(
-                        new Preference.OnPreferenceClickListener() {
-                            @Override
-                            public boolean onPreferenceClick(Preference preference) {
-                                if (Build.VERSION.SDK_INT >= 19) {
-                                    showChooseDataFolderDialog();
-                                } else {
-                                    Intent intent = new Intent(activity, DirectoryChooserActivity.class);
-                                    activity.startActivityForResult(intent,
-                                            DirectoryChooserActivity.RESULT_CODE_DIR_SELECTED);
-                                }
-                                return true;
+                        preference -> {
+                            if (Build.VERSION.SDK_INT >= 19) {
+                                showChooseDataFolderDialog();
+                            } else {
+                                Intent intent = new Intent(activity, DirectoryChooserActivity.class);
+                                activity.startActivityForResult(intent,
+                                        DirectoryChooserActivity.RESULT_CODE_DIR_SELECTED);
                             }
-                }
-        );
+                            return true;
+                        }
+                );
         ui.findPreference(UserPreferences.PREF_THEME)
                 .setOnPreferenceChangeListener(
                         (preference, newValue) -> {
@@ -630,7 +627,7 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
             Preference.OnPreferenceClickListener clickListener = preference -> {
                 if (preference instanceof CheckBoxPreference) {
                     String key = preference.getKey();
-                    ArrayList<String> prefValuesList = new ArrayList<String>(
+                    ArrayList<String> prefValuesList = new ArrayList<>(
                             Arrays.asList(UserPreferences
                                     .getAutodownloadSelectedNetworks())
                     );
@@ -639,10 +636,10 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
                     Log.d(TAG, "Selected network " + key + ". New state: " + newValue);
 
                     int index = prefValuesList.indexOf(key);
-                    if (index >= 0 && newValue == false) {
+                    if (index >= 0 && !newValue) {
                         // remove network
                         prefValuesList.remove(index);
-                    } else if (index < 0 && newValue == true) {
+                    } else if (index < 0 && newValue) {
                         prefValuesList.add(key);
                     }
 
@@ -678,9 +675,9 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
         if (selectedNetworks != null) {
             PreferenceScreen prefScreen = (PreferenceScreen) ui.findPreference(PreferenceController.AUTO_DL_PREF_SCREEN);
 
-            for (int i = 0; i < selectedNetworks.length; i++) {
-                if (selectedNetworks[i] != null) {
-                    prefScreen.removePreference(selectedNetworks[i]);
+            for (CheckBoxPreference network : selectedNetworks) {
+                if (network != null) {
+                    prefScreen.removePreference(network);
                 }
             }
         }
-- 
cgit v1.2.3