Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-04-06 | #2966 RxJava2 null - case underlying method has needs to return null. | orionlee | |
Need to wrap return result with Optional<> Mark code path with TODO. Actual fix is pending #2954 merge. Rx observer: underlying sources that need to return Optional<> OnlineFeedViewActivity.parseFeed : <anonymous subscriber> PlaybackController.bindToService : fixed in #2954 | |||
2019-04-06 | #2966 RxJava2 null - case the underlying method may return null, but | orionlee | |
should never happen in the code path, e.g., return the current FeedItem in ItemFragment UI. Mark underlying method as @Nullable, and let observer's existing onError() to handle null case Rx observer : underlying sources marked as @Nullable ItemFragment.load : .loadInBackground MediaplayerActivity.checkFavorite : DBReader.getFeedItem ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem ItemlistFragment.loadItems : .loadData | |||
2019-04-06 | #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull | orionlee | |
to be on the safe side, for cases that the consuming observers checks null unnecessarily. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.startFeedDownload : Downloader.getResult AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory QueueFragment.loadItems : DBReader.getQueue SearchFragment.search : .performSearch | |||
2019-04-06 | #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull | orionlee | |
to be on the safe side, for cases that the consuming observers already assumes the result is not null. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.listener member : DBReader.getFeedList StatisticsActivity.loadStatistics : DBReader.getStatistics CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems DownloadLogFragment.loadItems : DBReader.getDownloadedItems ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead PreferenceController.export : ExportWorker.output member | |||
2019-04-06 | Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145 | H. Lehmann | |
Bulk remove from queue | |||
2019-04-06 | Show single item after undo in EpisodesFragment | ByteHamster | |
2019-04-06 | refactor - rename string resource name `remove_episode_lable` , which was ↵ | orionlee | |
ambiguous with typos, to `delete_episode_label` - non-default string resources to be handled by Transifex | |||
2019-04-06 | tweak - batch edit UI - support longer action label | orionlee | |
2019-04-06 | remove comment to reduce mental work per review feedback | orionlee | |
2019-04-06 | tweak - bulk edit UI - remove hiding FAB during scroll per review feedback | orionlee | |
2019-04-06 | tweak - bulk edit UI - use Snackbar for selection message | orionlee | |
- to be consistent with the action message in previous commit. | |||
2019-04-06 | tweak - bulk edit UI - show a message after an action is applied. | orionlee | |
2019-04-06 | refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without ↵ | orionlee | |
custom codes. | |||
2019-04-06 | Create new adapter to show single item after undo | Martin Fietz | |
2019-04-04 | refactor - UI - make OPML import screen use the new select all / none icons ↵ | orionlee | |
as well (so that only single set of icons are needed) | |||
2019-04-04 | bulk edit - UI - new select all / none icons, based on | orionlee | |
standard Material icons. | |||
2019-04-04 | bulk remove episodes from queue - UI - icon for dark themes. | orionlee | |
2019-04-04 | Merge pull request #3086 from ByteHamster/fix-double-slash-url | Martin Fietz | |
Specifying base url | |||
2019-04-04 | Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716 | H. Lehmann | |
Fix phantom service notification | |||
2019-04-03 | bulk edit - refactor - reorder method parameter for ↵ | orionlee | |
DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API. | |||
2019-04-03 | bulk edit - refactor - factorize common codes in binding action to its UI ↵ | orionlee | |
and actual logic. | |||
2019-04-03 | bulk edit - refactor - rename menu ids, to be consistent with single edit ↵ | orionlee | |
counterparts | |||
2019-04-03 | bulk edit - refactor - rename internal constant flags so that the names are ↵ | orionlee | |
consistent | |||
2019-04-03 | Specifying base url | ByteHamster | |
Fixes <a href="//example.com"> links | |||
2019-04-03 | Merge pull request #3082 from ByteHamster/mobile-updates | H. Lehmann | |
Mobile updates: Allow images | |||
2019-04-03 | Merge pull request #3060 from jatinkumarg/issue-3052 | H. Lehmann | |
Added empty views to the PlayBack History, Queue,and Downloads | |||
2019-04-02 | bulk edit - no longer defaulted to check all | orionlee | |
2019-04-02 | bulk edit - "N selected" UI logic | orionlee | |
2019-04-02 | fix typo in comments | orionlee | |
2019-04-02 | bulk remove from queue - backend - implement the new API | orionlee | |
2019-04-02 | Renamed text view ids and added tools namespace | Jatin Kumar | |
2019-04-02 | bulk remove from queue - frontend logic, with a stub backend. | orionlee | |
2019-04-02 | document android:elevation API compatibility | orionlee | |
2019-04-02 | batch edit - replace the bottom button UI with FAB Speed Dial (no new ↵ | orionlee | |
actions yet) | |||
2019-04-02 | fix speed dial buttons order | orionlee | |
2019-04-02 | ensure speed dials clickable (for pre-Android 5 devices) | orionlee | |
2019-04-02 | stub speed action action listener | orionlee | |
2019-04-02 | make speed dials scrollable, so that they work in landscape / split window mode. | orionlee | |
2019-04-02 | UI Prototype for Batch Edit Episodes rework (from #1145) | orionlee | |
2019-04-02 | Add preference to allow mobile updates of images | ByteHamster | |
2019-04-01 | Added include to the queue and episode layout | Jatin Kumar | |
2019-03-30 | Updated text sizes from dp to sp | Jatin Kumar | |
2019-03-29 | Change the icons in interface #3040 | Matias de Andrea | |
2019-03-29 | Fixed typos | Jatin Kumar | |
2019-03-27 | Updated NewEpisodesFragment and FavoriteEpisodesFragment files | Jatin Kumar | |
2019-03-27 | Fixes #3052: Added empty views to the Playback History, Queue, Downloads and ↵ | Jatin Kumar | |
Episodes | |||
2019-03-23 | Fixed FeedHandlerTest | ByteHamster | |
2019-03-21 | Added empty views to the PlayBack History, Queue,and Downloads | Jatin Kumar | |
2019-03-09 | bugfix - video playback upon press back button (and pause), playback ↵ | orionlee | |
notification might reappear if one swipes it away quickly. | |||
2019-03-08 | Merge pull request #3048 from ByteHamster/new-episodes-download | H. Lehmann | |
Fixed download status update in NewEpisodesFragment |