Age | Commit message (Collapse) | Author |
|
|
|
Simplify empty view handling on recycler views
|
|
The method is called again with a valid listAdapter automatically
Closes #3154
|
|
|
|
|
|
Fixed empty list not receiving updates
|
|
|
|
RxJava 2.x no longer accepts `null` values and will yield a
`NullPointerException` immediately or as a signal to downstream [1].
This returns an Optional<Feed> instead to avoid errors.
[1]: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#nulls
|
|
When adding certain podcasts [1], a `LeakedClosableViolation` is thrown
due to the fact that we're reusing the OkHttpClient to make multiple
requests (one to get the iTunes toplist for the user's language, and
another one defaulting to US).
This makes sure that all requests are closed to prevent this exception,
according to OkHttp docs [2].
[1]: https://podcasts.apple.com/us/podcast/stupid-genius-with-emma-chamberlain/id1458568923
[2]: https://github.com/square/okhttp/blob/18f2b5e/okhttp/src/main/java/okhttp3/Call.kt#L32-L40
|
|
|
|
Closes #3138
|
|
Removes redundant casts and adds generic type to avoid compiler warnings.
|
|
Hiding ExternalPlayerFragment onStart
|
|
If the playback is finished in background, the fragmentLayout is not hidden.
Steps to reproduce (without this commit):
- Start last item in queue
- Leave app using home button
- Finish playback by using notification skip button
- Resume to AntennaPod
- ExternalPlayerFragment is shown (in invalid state) but should be hidden
|
|
|
|
|
|
Fixed NPE
|
|
|
|
|
|
Set number of subscription columns
|
|
|
|
|
|
Executing all ExoPlayer methods on main thread
|
|
Do not hold state in fragments
|
|
|
|
|
|
orionlee/bugfix_bulk_action_ui_survive_split_screen_3088
bugfix - bulk actions - make UI survive upon split screen
|
|
feed.
|
|
|
|
|
|
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.
Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
|
|
should never happen in the code path, e.g.,
return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
onError() to handle null case
Rx observer : underlying sources marked as @Nullable
ItemFragment.load : .loadInBackground
MediaplayerActivity.checkFavorite : DBReader.getFeedItem
ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
ItemlistFragment.loadItems : .loadData
|
|
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
|
|
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
|
|
Bulk remove from queue
|
|
|
|
|
|
- to be consistent with the action message in previous commit.
|
|
|
|
custom codes.
|
|
|
|
standard Material icons.
|
|
Specifying base url
|
|
Fix phantom service notification
|
|
DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
|
|
and actual logic.
|
|
counterparts
|
|
consistent
|
|
Fixes <a href="//example.com"> links
|
|
|