Age | Commit message (Collapse) | Author | |
---|---|---|---|
2019-04-28 | Close OkHttp request before making new ones | Anderson Mesquita | |
When adding certain podcasts [1], a `LeakedClosableViolation` is thrown due to the fact that we're reusing the OkHttpClient to make multiple requests (one to get the iTunes toplist for the user's language, and another one defaulting to US). This makes sure that all requests are closed to prevent this exception, according to OkHttp docs [2]. [1]: https://podcasts.apple.com/us/podcast/stupid-genius-with-emma-chamberlain/id1458568923 [2]: https://github.com/square/okhttp/blob/18f2b5e/okhttp/src/main/java/okhttp3/Call.kt#L32-L40 | |||
2019-04-28 | Made null check work | ByteHamster | |
2019-04-26 | Fixed crash where recyclerAdapter is null | ByteHamster | |
Closes #3138 | |||
2019-04-25 | Cleanup compiler warnings | Anderson Mesquita | |
Removes redundant casts and adds generic type to avoid compiler warnings. | |||
2019-04-24 | Merge pull request #3131 from ByteHamster/fix-hiding-ExternalPlayer | H. Lehmann | |
Hiding ExternalPlayerFragment onStart | |||
2019-04-24 | Hiding ExternalPlayerFragment onStart | ByteHamster | |
If the playback is finished in background, the fragmentLayout is not hidden. Steps to reproduce (without this commit): - Start last item in queue - Leave app using home button - Finish playback by using notification skip button - Resume to AntennaPod - ExternalPlayerFragment is shown (in invalid state) but should be hidden | |||
2019-04-19 | bugfix #3092 - time left on Queue screen not updated after download completes | Ali | |
2019-04-13 | Fixed NPE | ByteHamster | |
2019-04-12 | Merge pull request #3113 from ByteHamster/fix-crash-npe | H. Lehmann | |
Fixed NPE | |||
2019-04-12 | Fixed NPE | ByteHamster | |
2019-04-12 | Fixed crash when re-using released controller | ByteHamster | |
2019-04-12 | Let PlaybackController handle listening for service start | ByteHamster | |
2019-04-12 | Upgraded EventBus to v3 | ByteHamster | |
Also made sure that register/unregister are called in onStart/onStop instead of onResume/onPause (prevents possible MultiWindow problems where updates are not received because activity is not fucused). | |||
2019-04-12 | Merge pull request #3106 from ByteHamster/subscriptions-columns | H. Lehmann | |
Set number of subscription columns | |||
2019-04-11 | Set number of subscription columns | ByteHamster | |
2019-04-11 | Fix displaying progress indicator in multi window | ByteHamster | |
2019-04-11 | Merge pull request #3097 from ByteHamster/exoplayer-main-thread | H. Lehmann | |
Executing all ExoPlayer methods on main thread | |||
2019-04-11 | Merge pull request #3102 from ByteHamster/no-state-in-fragments | H. Lehmann | |
Do not hold state in fragments | |||
2019-04-11 | Making sure that ExternalPlayerFragment is updated when starting first media | ByteHamster | |
2019-04-10 | Do not hold state in fragments | ByteHamster | |
2019-04-08 | Merge pull request #3100 from ↵ | Martin Fietz | |
orionlee/bugfix_bulk_action_ui_survive_split_screen_3088 bugfix - bulk actions - make UI survive upon split screen | |||
2019-04-07 | bugfix #3099 - add podcast by URL - show error dialog when URL points to no ↵ | orionlee | |
feed. | |||
2019-04-07 | bugfix #3088 - bulk edit - make UI survive upon split screen | orionlee | |
2019-04-06 | bugfix - rxjava2 null return - wrap nullable return with Optional | orionlee | |
2019-04-06 | #2966 RxJava2 null - case underlying method has needs to return null. | orionlee | |
Need to wrap return result with Optional<> Mark code path with TODO. Actual fix is pending #2954 merge. Rx observer: underlying sources that need to return Optional<> OnlineFeedViewActivity.parseFeed : <anonymous subscriber> PlaybackController.bindToService : fixed in #2954 | |||
2019-04-06 | #2966 RxJava2 null - case the underlying method may return null, but | orionlee | |
should never happen in the code path, e.g., return the current FeedItem in ItemFragment UI. Mark underlying method as @Nullable, and let observer's existing onError() to handle null case Rx observer : underlying sources marked as @Nullable ItemFragment.load : .loadInBackground MediaplayerActivity.checkFavorite : DBReader.getFeedItem ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem ItemlistFragment.loadItems : .loadData | |||
2019-04-06 | #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull | orionlee | |
to be on the safe side, for cases that the consuming observers checks null unnecessarily. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.startFeedDownload : Downloader.getResult AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory QueueFragment.loadItems : DBReader.getQueue SearchFragment.search : .performSearch | |||
2019-04-06 | #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull | orionlee | |
to be on the safe side, for cases that the consuming observers already assumes the result is not null. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.listener member : DBReader.getFeedList StatisticsActivity.loadStatistics : DBReader.getStatistics CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems DownloadLogFragment.loadItems : DBReader.getDownloadedItems ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead PreferenceController.export : ExportWorker.output member | |||
2019-04-06 | Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145 | H. Lehmann | |
Bulk remove from queue | |||
2019-04-06 | Show single item after undo in EpisodesFragment | ByteHamster | |
2019-04-06 | tweak - bulk edit UI - remove hiding FAB during scroll per review feedback | orionlee | |
2019-04-06 | tweak - bulk edit UI - use Snackbar for selection message | orionlee | |
- to be consistent with the action message in previous commit. | |||
2019-04-06 | tweak - bulk edit UI - show a message after an action is applied. | orionlee | |
2019-04-06 | refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without ↵ | orionlee | |
custom codes. | |||
2019-04-06 | Create new adapter to show single item after undo | Martin Fietz | |
2019-04-04 | bulk edit - UI - new select all / none icons, based on | orionlee | |
standard Material icons. | |||
2019-04-04 | Merge pull request #3086 from ByteHamster/fix-double-slash-url | Martin Fietz | |
Specifying base url | |||
2019-04-04 | Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716 | H. Lehmann | |
Fix phantom service notification | |||
2019-04-03 | bulk edit - refactor - reorder method parameter for ↵ | orionlee | |
DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API. | |||
2019-04-03 | bulk edit - refactor - factorize common codes in binding action to its UI ↵ | orionlee | |
and actual logic. | |||
2019-04-03 | bulk edit - refactor - rename menu ids, to be consistent with single edit ↵ | orionlee | |
counterparts | |||
2019-04-03 | bulk edit - refactor - rename internal constant flags so that the names are ↵ | orionlee | |
consistent | |||
2019-04-03 | Specifying base url | ByteHamster | |
Fixes <a href="//example.com"> links | |||
2019-04-02 | bulk edit - no longer defaulted to check all | orionlee | |
2019-04-02 | bulk edit - "N selected" UI logic | orionlee | |
2019-04-02 | fix typo in comments | orionlee | |
2019-04-02 | Renamed text view ids and added tools namespace | Jatin Kumar | |
2019-04-02 | bulk remove from queue - frontend logic, with a stub backend. | orionlee | |
2019-04-02 | batch edit - replace the bottom button UI with FAB Speed Dial (no new ↵ | orionlee | |
actions yet) | |||
2019-04-02 | ensure speed dials clickable (for pre-Android 5 devices) | orionlee | |