summaryrefslogtreecommitdiff
path: root/app/src/main/java/de/danoeh
AgeCommit message (Collapse)Author
2019-05-03Fixed NPE when selected item is nullByteHamster
The method is called again with a valid listAdapter automatically Closes #3154
2019-05-03Simplify empty view handling on recycler viewsByteHamster
2019-05-03Fixed about screen readability in amoled theme (Closes #3151)ByteHamster
2019-04-30Merge pull request #3147 from ByteHamster/fix-empty-listMartin Fietz
Fixed empty list not receiving updates
2019-04-30Fixed empty list not receiving updatesByteHamster
2019-04-30Return Optional feed when loading feed itemsAnderson Mesquita
RxJava 2.x no longer accepts `null` values and will yield a `NullPointerException` immediately or as a signal to downstream [1]. This returns an Optional<Feed> instead to avoid errors. [1]: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#nulls
2019-04-28force refresh time when playback speed changeCédric Cabessa
This is useful when media is paused
2019-04-28use time converter and pref in MediaPlayer and WidgetCédric Cabessa
2019-04-28Close OkHttp request before making new onesAnderson Mesquita
When adding certain podcasts [1], a `LeakedClosableViolation` is thrown due to the fact that we're reusing the OkHttpClient to make multiple requests (one to get the iTunes toplist for the user's language, and another one defaulting to US). This makes sure that all requests are closed to prevent this exception, according to OkHttp docs [2]. [1]: https://podcasts.apple.com/us/podcast/stupid-genius-with-emma-chamberlain/id1458568923 [2]: https://github.com/square/okhttp/blob/18f2b5e/okhttp/src/main/java/okhttp3/Call.kt#L32-L40
2019-04-28Made null check workByteHamster
2019-04-26Fixed crash where recyclerAdapter is nullByteHamster
Closes #3138
2019-04-25Cleanup compiler warningsAnderson Mesquita
Removes redundant casts and adds generic type to avoid compiler warnings.
2019-04-24Merge pull request #3131 from ByteHamster/fix-hiding-ExternalPlayerH. Lehmann
Hiding ExternalPlayerFragment onStart
2019-04-24Hiding ExternalPlayerFragment onStartByteHamster
If the playback is finished in background, the fragmentLayout is not hidden. Steps to reproduce (without this commit): - Start last item in queue - Leave app using home button - Finish playback by using notification skip button - Resume to AntennaPod - ExternalPlayerFragment is shown (in invalid state) but should be hidden
2019-04-19bugfix #3092 - time left on Queue screen not updated after download completesAli
2019-04-13Fixed NPEByteHamster
2019-04-12Merge pull request #3113 from ByteHamster/fix-crash-npeH. Lehmann
Fixed NPE
2019-04-12Fixed NPEByteHamster
2019-04-12Fixed crash when re-using released controllerByteHamster
2019-04-12Let PlaybackController handle listening for service startByteHamster
2019-04-12Upgraded EventBus to v3ByteHamster
Also made sure that register/unregister are called in onStart/onStop instead of onResume/onPause (prevents possible MultiWindow problems where updates are not received because activity is not fucused).
2019-04-12Merge pull request #3106 from ByteHamster/subscriptions-columnsH. Lehmann
Set number of subscription columns
2019-04-11Set number of subscription columnsByteHamster
2019-04-11Fix displaying progress indicator in multi windowByteHamster
2019-04-11Merge pull request #3097 from ByteHamster/exoplayer-main-threadH. Lehmann
Executing all ExoPlayer methods on main thread
2019-04-11Merge pull request #3102 from ByteHamster/no-state-in-fragmentsH. Lehmann
Do not hold state in fragments
2019-04-11Making sure that ExternalPlayerFragment is updated when starting first mediaByteHamster
2019-04-10Do not hold state in fragmentsByteHamster
2019-04-08Merge pull request #3100 from ↵Martin Fietz
orionlee/bugfix_bulk_action_ui_survive_split_screen_3088 bugfix - bulk actions - make UI survive upon split screen
2019-04-07bugfix #3099 - add podcast by URL - show error dialog when URL points to no ↵orionlee
feed.
2019-04-07bugfix #3088 - bulk edit - make UI survive upon split screenorionlee
2019-04-06bugfix - rxjava2 null return - wrap nullable return with Optionalorionlee
2019-04-06#2966 RxJava2 null - case underlying method has needs to return null.orionlee
Need to wrap return result with Optional<> Mark code path with TODO. Actual fix is pending #2954 merge. Rx observer: underlying sources that need to return Optional<> OnlineFeedViewActivity.parseFeed : <anonymous subscriber> PlaybackController.bindToService : fixed in #2954
2019-04-06#2966 RxJava2 null - case the underlying method may return null, butorionlee
should never happen in the code path, e.g., return the current FeedItem in ItemFragment UI. Mark underlying method as @Nullable, and let observer's existing onError() to handle null case Rx observer : underlying sources marked as @Nullable ItemFragment.load : .loadInBackground MediaplayerActivity.checkFavorite : DBReader.getFeedItem ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem ItemlistFragment.loadItems : .loadData
2019-04-06#2966 RxJava2 null - explicit mark underlying Rx sources as NonNullorionlee
to be on the safe side, for cases that the consuming observers checks null unnecessarily. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.startFeedDownload : Downloader.getResult AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory QueueFragment.loadItems : DBReader.getQueue SearchFragment.search : .performSearch
2019-04-06#2966 RxJava2 null - explicit mark underlying Rx sources as NonNullorionlee
to be on the safe side, for cases that the consuming observers already assumes the result is not null. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.listener member : DBReader.getFeedList StatisticsActivity.loadStatistics : DBReader.getStatistics CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems DownloadLogFragment.loadItems : DBReader.getDownloadedItems ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead PreferenceController.export : ExportWorker.output member
2019-04-06Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145H. Lehmann
Bulk remove from queue
2019-04-06Show single item after undo in EpisodesFragmentByteHamster
2019-04-06tweak - bulk edit UI - remove hiding FAB during scroll per review feedbackorionlee
2019-04-06tweak - bulk edit UI - use Snackbar for selection messageorionlee
- to be consistent with the action message in previous commit.
2019-04-06tweak - bulk edit UI - show a message after an action is applied.orionlee
2019-04-06refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without ↵orionlee
custom codes.
2019-04-06Create new adapter to show single item after undoMartin Fietz
2019-04-04bulk edit - UI - new select all / none icons, based onorionlee
standard Material icons.
2019-04-04Merge pull request #3086 from ByteHamster/fix-double-slash-urlMartin Fietz
Specifying base url
2019-04-04Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716H. Lehmann
Fix phantom service notification
2019-04-03bulk edit - refactor - reorder method parameter for ↵orionlee
DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
2019-04-03bulk edit - refactor - factorize common codes in binding action to its UI ↵orionlee
and actual logic.
2019-04-03bulk edit - refactor - rename menu ids, to be consistent with single edit ↵orionlee
counterparts
2019-04-03bulk edit - refactor - rename internal constant flags so that the names are ↵orionlee
consistent
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-18 08:43:03 +0000