summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-07bugfix #3088 - bulk edit - make UI survive upon split screenorionlee
2019-04-07Merge pull request #2974 from orionlee/bugfix_rxjava2_null_returns_2966H. Lehmann
Fix rxjava2 null returns
2019-04-06bugfix - rxjava2 null return - wrap nullable return with Optionalorionlee
2019-04-06fix rebase conflicts - remove the incorrect @NonNull from rxjavaorionlee
2019-04-06#2966 RxJava2 null - case underlying method has needs to return null.orionlee
Need to wrap return result with Optional<> Mark code path with TODO. Actual fix is pending #2954 merge. Rx observer: underlying sources that need to return Optional<> OnlineFeedViewActivity.parseFeed : <anonymous subscriber> PlaybackController.bindToService : fixed in #2954
2019-04-06#2966 RxJava2 null - case the underlying method may return null, butorionlee
should never happen in the code path, e.g., return the current FeedItem in ItemFragment UI. Mark underlying method as @Nullable, and let observer's existing onError() to handle null case Rx observer : underlying sources marked as @Nullable ItemFragment.load : .loadInBackground MediaplayerActivity.checkFavorite : DBReader.getFeedItem ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem ItemlistFragment.loadItems : .loadData
2019-04-06#2966 RxJava2 null - explicit mark underlying Rx sources as NonNullorionlee
to be on the safe side, for cases that the consuming observers checks null unnecessarily. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.startFeedDownload : Downloader.getResult AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory QueueFragment.loadItems : DBReader.getQueue SearchFragment.search : .performSearch
2019-04-06#2966 RxJava2 null - explicit mark underlying Rx sources as NonNullorionlee
to be on the safe side, for cases that the consuming observers already assumes the result is not null. Rx observer : underlying sources marked as NonNull OnlineFeedViewActivity.listener member : DBReader.getFeedList StatisticsActivity.loadStatistics : DBReader.getStatistics CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems DownloadLogFragment.loadItems : DBReader.getDownloadedItems ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead PreferenceController.export : ExportWorker.output member
2019-04-06Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145H. Lehmann
Bulk remove from queue
2019-04-06Merge pull request #3093 from AntennaPod/bugfix/3084-queue-undo-singleH. Lehmann
Create new adapter to show single item after undo
2019-04-06Show single item after undo in EpisodesFragmentByteHamster
2019-04-06refactor - rename string resource name `remove_episode_lable` , which was ↵orionlee
ambiguous with typos, to `delete_episode_label` - non-default string resources to be handled by Transifex
2019-04-06tweak - batch edit UI - support longer action labelorionlee
2019-04-06remove comment to reduce mental work per review feedbackorionlee
2019-04-06remove outdated comment - support for vector drawables for pre Android 5 ↵orionlee
devices is here to stay.
2019-04-06tweak - bulk edit UI - remove hiding FAB during scroll per review feedbackorionlee
2019-04-06tweak - bulk edit UI - use Snackbar for selection messageorionlee
- to be consistent with the action message in previous commit.
2019-04-06tweak - bulk edit UI - show a message after an action is applied.orionlee
2019-04-06refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without ↵orionlee
custom codes.
2019-04-06Create new adapter to show single item after undoMartin Fietz
2019-04-04refactor - UI - remove the old (and now used) select all / none ↵orionlee
/intermediate icons
2019-04-04refactor - UI - make OPML import screen use the new select all / none icons ↵orionlee
as well (so that only single set of icons are needed)
2019-04-04bulk edit - UI - new select all / none icons, based onorionlee
standard Material icons.
2019-04-04bulk remove episodes from queue - UI - icon for dark themes.orionlee
2019-04-04Merge pull request #3086 from ByteHamster/fix-double-slash-urlMartin Fietz
Specifying base url
2019-04-04Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716H. Lehmann
Fix phantom service notification
2019-04-04Merge pull request #3085 from ByteHamster/new-items-countH. Lehmann
Respect 'keep updated' for new items counter
2019-04-03bulk edit - refactor - reorder method parameter for ↵orionlee
DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
2019-04-03bulk edit - refactor - factorize common codes in binding action to its UI ↵orionlee
and actual logic.
2019-04-03bulk edit - refactor - rename menu ids, to be consistent with single edit ↵orionlee
counterparts
2019-04-03bulk edit - refactor - rename internal constant flags so that the names are ↵orionlee
consistent
2019-04-03bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be ↵orionlee
consistent with other UIs
2019-04-03Specifying base urlByteHamster
Fixes <a href="//example.com"> links
2019-04-03Respect 'keep updated' for new items counterByteHamster
2019-04-03Merge pull request #3082 from ByteHamster/mobile-updatesH. Lehmann
Mobile updates: Allow images
2019-04-03Merge pull request #3060 from jatinkumarg/issue-3052H. Lehmann
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03Review changesByteHamster
2019-04-02bulk edit - no longer defaulted to check allorionlee
2019-04-02bulk edit - "N selected" UI logicorionlee
2019-04-02fix typo in commentsorionlee
2019-04-02bulk remove from queue - backend - implement the new APIorionlee
2019-04-02bulk remove from queue - backend - refactor existing logic to support bulk ↵orionlee
remove
2019-04-02Renamed text view ids and added tools namespaceJatin Kumar
2019-04-02bulk remove from queue - frontend logic, with a stub backend.orionlee
2019-04-02document android:elevation API compatibilityorionlee
2019-04-02batch edit - replace the bottom button UI with FAB Speed Dial (no new ↵orionlee
actions yet)
2019-04-02fix speed dial buttons orderorionlee
2019-04-02ensure speed dials clickable (for pre-Android 5 devices)orionlee
2019-04-02stub speed action action listenerorionlee
2019-04-02make speed dials scrollable, so that they work in landscape / split window mode.orionlee
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-14 21:31:20 +0000