Merge pull request #2055 from DevFactory/release/Lamdbas_containing_only_one_statement_should_not_nest_this_statement_in_a_block

squid:S1602 - Lamdbas containing only one statement should not nest this statement in a block.

7 files changed, 17 insertions, 43 deletions

diff --git a/app/src/main/java/de/danoeh/antennapod/activity/AboutActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/AboutActivity.java
index eef2fa4da..1b42b274c 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/AboutActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/AboutActivity.java
@@ -124,12 +124,11 @@ public class AboutActivity extends AppCompatActivity {
                 })
                 .subscribeOn(Schedulers.newThread())
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribe(webviewData -> {
-                    webview.loadDataWithBaseURL("file:///android_asset/", webviewData, "text/html",
-                            "utf-8", "about:blank");
-                }, error -> {
-                    Log.e(TAG, Log.getStackTraceString(error));
-                });
+                .subscribe(
+                        webviewData ->
+                                webview.loadDataWithBaseURL("file:///android_asset/", webviewData, "text/html", "utf-8", "about:blank"),
+                        error -> Log.e(TAG, Log.getStackTraceString(error))
+                );
     }
 
     @Override
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/DirectoryChooserActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/DirectoryChooserActivity.java
index 5fd69ef6a..390d4cef8 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/DirectoryChooserActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/DirectoryChooserActivity.java
@@ -89,9 +89,7 @@ public class DirectoryChooserActivity extends AppCompatActivity {
                 adb.setTitle(R.string.folder_not_empty_dialog_title);
                 adb.setMessage(R.string.folder_not_empty_dialog_msg);
                 adb.setNegativeButton(R.string.cancel_label,
-                        (dialog, which) -> {
-                            dialog.dismiss();
-                        });
+                        (dialog, which) -> dialog.dismiss());
                 adb.setPositiveButton(R.string.confirm_label,
                         (dialog, which) -> {
                             dialog.dismiss();
@@ -291,9 +289,7 @@ public class DirectoryChooserActivity extends AppCompatActivity {
         builder.setMessage(String.format(getString(R.string.create_folder_msg),
                 CREATE_DIRECTORY_NAME));
         builder.setNegativeButton(R.string.cancel_label,
-                (dialog, which) -> {
-                    dialog.dismiss();
-                });
+                (dialog, which) -> dialog.dismiss());
         builder.setPositiveButton(R.string.confirm_label,
                 (dialog, which) -> {
                     dialog.dismiss();
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java
index 447edc567..97732786e 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/MainActivity.java
@@ -149,9 +149,7 @@ public class MainActivity extends CastEnabledActivity implements NavDrawerActivi
 
         final FragmentManager fm = getSupportFragmentManager();
 
-        fm.addOnBackStackChangedListener(() -> {
-            drawerToggle.setDrawerIndicatorEnabled(fm.getBackStackEntryCount() == 0);
-        });
+        fm.addOnBackStackChangedListener(() -> drawerToggle.setDrawerIndicatorEnabled(fm.getBackStackEntryCount() == 0));
 
         getSupportActionBar().setDisplayHomeAsUpEnabled(true);
         getSupportActionBar().setHomeButtonEnabled(true);
@@ -255,9 +253,7 @@ public class MainActivity extends CastEnabledActivity implements NavDrawerActivi
                 hiddenDrawerItems.add(NAV_DRAWER_TAGS[which]);
             }
         });
-        builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> {
-            UserPreferences.setHiddenDrawerItems(hiddenDrawerItems);
-        });
+        builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> UserPreferences.setHiddenDrawerItems(hiddenDrawerItems));
         builder.setNegativeButton(R.string.cancel_label, null);
         builder.create().show();
     }
@@ -703,9 +699,7 @@ public class MainActivity extends CastEnabledActivity implements NavDrawerActivi
                     if (handleIntent) {
                         handleNavIntent();
                     }
-                }, error -> {
-                    Log.e(TAG, Log.getStackTraceString(error));
-                });
+                }, error -> Log.e(TAG, Log.getStackTraceString(error)));
     }
 
     public void onEvent(QueueEvent event) {
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
index 6803bd91d..48b578be7 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerActivity.java
@@ -724,9 +724,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
                     AlertDialog.Builder builder = new AlertDialog.Builder(MediaplayerActivity.this);
                     builder.setTitle(R.string.pref_rewind);
                     builder.setSingleChoiceItems(choices, checked,
-                            (dialog, which) -> {
-                                choice = values[which];
-                            });
+                            (dialog, which) -> choice = values[which]);
                     builder.setNegativeButton(R.string.cancel_label, null);
                     builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> {
                         UserPreferences.setPrefRewindSecs(choice);
@@ -764,9 +762,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
                     AlertDialog.Builder builder = new AlertDialog.Builder(MediaplayerActivity.this);
                     builder.setTitle(R.string.pref_fast_forward);
                     builder.setSingleChoiceItems(choices, checked,
-                            (dialog, which) -> {
-                                choice = values[which];
-                            });
+                            (dialog, which) -> choice = values[which]);
                     builder.setNegativeButton(R.string.cancel_label, null);
                     builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> {
                         UserPreferences.setPrefFastForwardSecs(choice);
@@ -867,10 +863,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
                                 isFavorite = isFav;
                                 invalidateOptionsMenu();
                             }
-                        }, error -> {
-                            Log.e(TAG, Log.getStackTraceString(error));
-                        }
-                    );
+                        }, error -> Log.e(TAG, Log.getStackTraceString(error)));
             }
         }
     }
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
index 3be881ccc..2880b26e8 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
@@ -443,9 +443,7 @@ public abstract class MediaplayerInfoActivity extends MediaplayerActivity implem
                 hiddenDrawerItems.add(NAV_DRAWER_TAGS[which]);
             }
         });
-        builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> {
-            UserPreferences.setHiddenDrawerItems(hiddenDrawerItems);
-        });
+        builder.setPositiveButton(R.string.confirm_label, (dialog, which) -> UserPreferences.setHiddenDrawerItems(hiddenDrawerItems));
         builder.setNegativeButton(R.string.cancel_label, null);
         builder.create().show();
     }
@@ -461,9 +459,7 @@ public abstract class MediaplayerInfoActivity extends MediaplayerActivity implem
                     if (navAdapter != null) {
                         navAdapter.notifyDataSetChanged();
                     }
-                }, error -> {
-                    Log.e(TAG, Log.getStackTraceString(error));
-                });
+                }, error -> Log.e(TAG, Log.getStackTraceString(error)));
     }
 
 
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/OnlineFeedViewActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/OnlineFeedViewActivity.java
index a53f9bdb8..f393b4cc7 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/OnlineFeedViewActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/OnlineFeedViewActivity.java
@@ -514,9 +514,7 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
                 builder.setMessage(R.string.error_msg_prefix);
             }
             builder.setNeutralButton(android.R.string.ok,
-                    (dialog, which) -> {
-                        dialog.cancel();
-                    }
+                    (dialog, which) -> dialog.cancel()
             );
             builder.setOnCancelListener(dialog -> {
                 setResult(RESULT_ERROR);
diff --git a/app/src/main/java/de/danoeh/antennapod/activity/StatisticsActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/StatisticsActivity.java
index 0254617e4..9bb8f8856 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/StatisticsActivity.java
+++ b/app/src/main/java/de/danoeh/antennapod/activity/StatisticsActivity.java
@@ -85,9 +85,7 @@ public class StatisticsActivity extends AppCompatActivity
                         totalTimeTextView.setVisibility(View.VISIBLE);
                         feedStatisticsList.setVisibility(View.VISIBLE);
                     }
-                }, error -> {
-                    Log.e(TAG, Log.getStackTraceString(error));
-                });
+                }, error -> Log.e(TAG, Log.getStackTraceString(error)));
     }
 
     @Override